X12S - GPS on AUX2

[chphoto80]

Is there an existing issue for this problem?

• I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Yesterday I installed firmware 2.10.5 on the Horus X12S and in Hardware I set Telemetry Mirror on AUX2. I disconnected the internal GPS module (no need to use). After turning the radio off and on, GPS is set again on AUX2. I created a custom build where I disabled the Internal GPS flag, but there was no change. After radio off and on, GPS is set on AUX2.

Expected Behavior

I expected the settings to be retained even after the transmitter was turned off.

Steps To Reproduce

1. HW set AUX2 to Telemetry Mirror
2. Radio Turn off
3. Radio Turn on
4. HW - AUX2 set to GPS by system

Version

2.10.5

Transmitter

FrSky X12

Operating System (OS)

Windows

OS Version

No response

Anything else?

No response

[pfeerick]

So just to confirm, you did a build for X12 with -DINTERNAL_GPS=N set, on the Radio Settings => Version page it does not list internalgps (like shown below), but still keeps reverting to GPS for the AUX2 setting?

[pfeerick]

Ok, I see the problem - this is blindly setting it to GPS on the X12S regardless of if internal GPS is compiled in or not...

edgetx/radio/src/storage/storage_common.cpp

Lines 93 to 96 in 14adf04

	#if defined(PCBX12S)
	// AUX2 is hardwired to AUX2 on X12S
	serialSetMode(SP_AUX2, UART_MODE_GPS);
	#endif

[chphoto80]

So just to confirm, you did a build for X12 with -DINTERNAL_GPS=N set, on the Radio Settings => Version page it does not list internalgps (like shown below), but still keeps reverting to GPS for the AUX2 setting?

Yes, I make Internal GPS = No - as show on my image