Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T16 w/o touch hard lockup after flashing master firmware #5328

Open
1 task done
TomasJot opened this issue Jul 26, 2024 · 9 comments · May be fixed by #5868
Open
1 task done

T16 w/o touch hard lockup after flashing master firmware #5328

TomasJot opened this issue Jul 26, 2024 · 9 comments · May be fixed by #5868
Assignees
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Milestone

Comments

@TomasJot
Copy link

Is there an existing issue for this problem?

  • I have searched the existing issues

What part of EdgeTX is the focus of this bug?

Transmitter firmware

Current Behavior

Blank screen, hard lockup, have to disconnect battery.

Expected Behavior

Boot succesfull.

Steps To Reproduce

Build from commit d0791fa - "chores: touch init in board (#5284)" on T16 w/o touchscreen.

Version

Nightly (Please give date/commit below)

Transmitter

Jumper T16

Operating System (OS)

No response

OS Version

No response

Anything else?

Problem was introduced after moving touchPanelInit() from radio/src/opentx.cpp to radio/src/targets/horus/board.cpp
I guess on radios with touchscreen all woks fine, only on horus radio w/o touch it causes hard lockup...

@TomasJot TomasJot added bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Jul 26, 2024
@pfeerick
Copy link
Member

I can reproduce this with T16 - latest nightly 3d8854a as well as d0791fa. Immediately prior commit b630982 boots fine.

@pfeerick pfeerick added bug/regression ↩️ A new version of EdgeTX broke something and removed bug 🪲 Something isn't working triage Bug report awaiting review / sorting labels Jul 27, 2024
@pfeerick pfeerick added this to the 2.11 milestone Jul 27, 2024
@3djc
Copy link
Collaborator

3djc commented Jul 27, 2024

Don't have a T16, so tried to reproduce on TX16S and disconnecting the touch panel, unfortunately (well, kinda) it works fine

@TomasJot
Copy link
Author

Any luck with this issue? (I'm afraid to wear out battery connector of my T16...:)

@TomasJot
Copy link
Author

TomasJot commented Oct 9, 2024

I still have a hope, so did some further digging... According to available schematics, T16 and TX16s have some hardware differences. On TX16S SCL and SDA signals to touchscreen connector have pullup resistors, on T16 those are trim buttons. Other 2 signals on T16 not connected - so do not have pull ups too.
Maybe it is possible to add cmake args -DHAVE_TOUCH=YES/NO for T16?

@raphaelcoeffic
Copy link
Member

raphaelcoeffic commented Dec 1, 2024

Other 2 signals on T16 not connected - so do not have pull ups too.

Might indeed be related to pull-ups. We should probably check the internal pull-ups are used in case no external ones are populated.

@TomasJot
Copy link
Author

TomasJot commented Dec 5, 2024

Is there something I can do to help fix this issue?

@gagarinlg
Copy link
Member

@pfeerick @TomasJot is this still an issue?

@pfeerick
Copy link
Member

pfeerick commented Jan 24, 2025

Yes. Latest nightly still results in T16 not booting - only the 6POS array flashing, so reverted it back to 2.10. One additional point - I DFU flashed so it had the matching bootloader, and I was able to enter the bootloader, but FWIW entering via the back door (Exit) did not work either. I will try and look at this further tomorrow or Sunday.

@pfeerick pfeerick assigned pfeerick and unassigned raphaelcoeffic Feb 5, 2025
pfeerick added a commit that referenced this issue Feb 5, 2025
Appears the double init locks up T16 if no TP present
Fixes #5328
@pfeerick pfeerick linked a pull request Feb 5, 2025 that will close this issue
@pfeerick
Copy link
Member

pfeerick commented Feb 5, 2025

Just tried again with latest nightly, radio still locks up on boot. A revert of d0791fa still works ... wait... touchPanelInit() is being called twice now. 🤦‍♂ Removing that seems to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression ↩️ A new version of EdgeTX broke something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants