From 1eab1ddca1fe0f7be92c57aad87f2eb11f2f92de Mon Sep 17 00:00:00 2001
From: krHERO <krHERO@users.noreply.github.com>
Date: Wed, 9 Oct 2024 15:35:24 +0200
Subject: [PATCH 1/2] Update pull_request_template.md

as agreed at the edirom community meeting 9.10.2024, we do not want to have tasks but (optional) bullet points.
---
 .github/pull_request_template.md | 28 +++++++++++++++-------------
 1 file changed, 15 insertions(+), 13 deletions(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index d78f1945a..afaed8097 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -9,18 +9,20 @@ Refs #
 <!--- Include details of your testing environment, and the tests you ran. -->
 
 ## Types of changes
-<!--- What types of changes does your code introduce? Please delete options that are not relevant. -->
-- [ ] Bug fix (non-breaking change which fixes an issue)
-- [ ] New feature (non-breaking change which adds functionality)
-- [ ] Breaking change (fix or feature that would cause existing functionality to change)
-- [ ] Documentation Update
+<!--- What types of changes does your code introduce? Please DELETEE options that are not relevant. -->
+- Bug fix (non-breaking change which fixes an issue)
+- New feature (non-breaking change which adds functionality)
+- Breaking change (fix or feature that would cause existing functionality to change)
+- Documentation Update
+- Improvement
+- Refactoring
 
-## Checklist
-<!--- Go over all the following points, and delete options that are not relevant. -->
+## Overview
+<!--- Go over all the following points, and DELETE options that are not relevant. -->
 <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
-- [ ] My change requires a change to the documentation.
-- [ ] I have updated the documentation accordingly.
-- [ ] I have performed a self-review of my code
-- [ ] I have read the [CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md) document.
-- [ ] I have added tests to cover my changes.
-- [ ] All new and existing tests passed.
+- My change requires a change to the documentation.
+- I have updated the documentation accordingly.
+- I have performed a self-review of my code
+- I have read the [CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md) document.
+- I have added tests to cover my changes.
+<!--- - All new and existing tests passed. -->

From b6779e4a5de9e9e96082fc45fff5402c15e3a287 Mon Sep 17 00:00:00 2001
From: krHERO <krHERO@users.noreply.github.com>
Date: Wed, 6 Nov 2024 15:39:44 +0100
Subject: [PATCH 2/2] Update pull_request_template.md

this commit adresses remarks of the review of @peterstadler

refs https://github.com/Edirom/Edirom-Online/pull/436
---
 .github/pull_request_template.md | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index afaed8097..c542e3508 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -20,9 +20,8 @@ Refs #
 ## Overview
 <!--- Go over all the following points, and DELETE options that are not relevant. -->
 <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
-- My change requires a change to the documentation.
-- I have updated the documentation accordingly.
-- I have performed a self-review of my code
+- I have updated the inline documentation accordingly.
+- I have performed a self-review of my code, according to the [style guide](https://github.com/Edirom/Edirom-Online/blob/develop/STYLE-GUIDE.md)
 - I have read the [CONTRIBUTING](https://github.com/Edirom/Edirom-Online/blob/develop/CONTRIBUTING.md) document.
-- I have added tests to cover my changes.
-<!--- - All new and existing tests passed. -->
+- I have added tests to cover my changes at [testing](https://github.com/Edirom/Edirom-Online/tree/develop/testing)
+- All new and existing tests passed.