Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with Foundry V11 and dnd5e 2.2.0 #80

Open
nschoenwald opened this issue May 25, 2023 · 3 comments
Open

Compatibility with Foundry V11 and dnd5e 2.2.0 #80

nschoenwald opened this issue May 25, 2023 · 3 comments

Comments

@nschoenwald
Copy link

Will this module be updated for the new releases of foundry and dnd5e? It's my favorite character sheet and I would love to keep using it!

@eastcw
Copy link

eastcw commented Jun 26, 2023

I think I have fixed all the issues my group have found with the sheet in dnd5e 2.2.0 (#81), but we aren't running Foundry 11 yet so I haven't verified it will work with that. I don't have permissions to merge my request or release a new version of the module though.

@mclearc
Copy link

mclearc commented Jun 29, 2023

Just to add to this that I'm on V11 and using the alpha release and having made the changes from @eastcw's branch I am seeing no problems -- everything is working as expected.

@JonathanAlumbaugh
Copy link

JonathanAlumbaugh commented Jul 4, 2023

First of all, thank you for this excellent module! This sheet is by far the most well organized and intuitive (even for non-DDB players) of all that I've tried. A quick test of @eastcw's fork looks like it is fixed there. Description of the issue below:

On Foundry v11.304 / DnD5e 2.2.1 with no other modules activated (except Character Actions List). It does appear to display correctly (screenshot below), but I get an error message in the console and no roll when trying to roll any skills (str/dex/con/etc... in the top row works fine):

Uncaught TypeError: Cannot read properties of null (reading 'dataset')
    at CompactBeyond5eSheet._onRollSkillCheck (base-sheet.mjs:1355:60)
    at HTMLHeadingElement.dispatch (jquery.min.js:2:43184)
    at y.handle (jquery.min.js:2:41168)

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants