Verified v10 compatiblity in Foundry module list

[benbarbour]

It's got the big yellow warning there, despite https://github.com/ElfFriend-DnD/foundryvtt-dnd5eCharacterActions/blob/main/src/module.json#L40. I re-installed this module, and went into the module.json on my disk and verified that that's there. I don't know if you need to add "verified", or "maximum" as well?

[benbarbour]

Maybe this could be considered a foundry bug?

[akrigline]

I apparently need verified as well. Haven't gotten to adding it yet though.

[farling42]

In another module, it was enough to only have the verified flag - the minimum flag was unnecessary.

[milesvdw]

It's actually not working for me in 10e,
foundryvtt-dnd5eCharacterActions.ts:61 Uncaught TypeError: app._onItemRoll is not a function

Also, a lot of this:

Error: You are accessing the Item5e#data object which is no longer used. Since V10 the Document class and its contained DataModel are merged into a combined data structure. You should now reference keys which were previously contained within the data object directly.
    at logCompatibilityWarning (commons.js:1692)
    at Function._logV10CompatibilityWarning (commons.js:6635)
    at Item5e.get data [as data] (commons.js:6535)
    at isItemInActionList (helpers.ts:95)
    at HTMLLIElement.<anonymous> (handleFavoriteControls.ts:66)
    at Function.each (jquery.min.js:2)
    at S.fn.init.each (jquery.min.js:2)
    at addFavoriteControls (handleFavoriteControls.ts:58)
    at Object.fn (foundryvtt-dnd5eCharacterActions.ts:172)

[milesvdw]

I see this is actually fixed in your source code:

if (getGame().settings.get(MODULE_ID, MySettings.includeOneMinuteSpells)) {
        const isOneMinuter = item.system?.duration?.units === 'minute' && item.system?.duration?.value === 1;
        const isOneRounder = item.system?.duration?.units === 'round' && item.system?.duration?.value === 1;

but when I go to update the module it's not pulling in those fixes.

[akrigline]

You might need to uninstall and reinstall to get these updates. I think the issue mentioned by the op is messing with "update"