Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanka-Foundry entries no longer work in GM Screen #98

Open
eXaminator opened this issue Jul 17, 2021 · 0 comments
Open

Kanka-Foundry entries no longer work in GM Screen #98

eXaminator opened this issue Jul 17, 2021 · 0 comments
Labels
bug Something isn't working compatibility Related to a different module

Comments

@eXaminator
Copy link

Environment Details

  • Foundry Core Version: 0.8.8

Describe the bug
I changed how the sheet class is selected for Kanka journal entries and this no longer works with how GM Screen works. This change on my end was made to be more future proof and hopefully improve the compatibility with other modules /systems (like PF2e) – I know, it's kind of ironic that this breaks compatibility in this case.

What I have changed is, that I use this shim by @zeel01: https://gist.github.com/zeel01/ffcbe77ad3e430fe44562e95a55d75e3

This adds the option to set sheets on a per document basis for journal entries, just as it is already possible for actors and items. This feature will probably (hopefully) also land as a core function in Foundry in the (near?) future. See the following issues in this regard:
https://gitlab.com/foundrynet/foundryvtt/-/issues/4994
https://gitlab.com/foundrynet/foundryvtt/-/issues/5298

This might have synergies with #95 as far as I can tell.

To Reproduce

  • Sync a kanka entity
  • Drag it to the GM screen
  • It uses the default sheet

Expected behavior
It should use the Kanka-Foundry specific sheet

@eXaminator eXaminator added the bug Something isn't working label Jul 17, 2021
@akrigline akrigline added the compatibility Related to a different module label Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working compatibility Related to a different module
Projects
None yet
Development

No branches or pull requests

2 participants