Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Protoc version handling #67

Closed
IronJulo opened this issue Nov 14, 2023 · 1 comment · Fixed by #68
Closed

Improve Protoc version handling #67

IronJulo opened this issue Nov 14, 2023 · 1 comment · Fixed by #68

Comments

@IronJulo
Copy link
Contributor

Issue Description

The current implementation assumes that Protobuf version always defines a major version, but there are cases where the major version may not always be present. As a result, the existing regular expression captures the minor number as the major and the patch number as the minor.

Existing Modifications

There have been prior attempts to handle this issue, but they do not seem to provide a reliable solution.

Context

Embedded Proto Version: 3.3.2

Expected Behavior

When encountering Protobuf versions without a major version, the version handling should correctly identify and capture major, minor, and patch numbers.

Observed Behavior

The script setup.py doesn't correctly identify and capture major, minor, and patch numbers.

Steps to Reproduce

  1. Encounter a Protobuf version without a major version (e.g., "libprotoc 25.0").
  2. Try to use the setup.py script.
@BartHertog
Copy link
Contributor

The issue has been resolved in #68. Thank you for your input.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants