Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Weird framepacing issues #8

Open
therealteamplayer opened this issue Jul 10, 2024 · 12 comments
Open

[BUG]: Weird framepacing issues #8

therealteamplayer opened this issue Jul 10, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@therealteamplayer
Copy link

therealteamplayer commented Jul 10, 2024

Describe the Bug

(edited from original post) Upon opening the app and then selecting a game, there can be severe microstuttering issues. So far I have tested Dark Cloud and Half-Life (at 300% overclock as the game lags on real hardware). Dark Cloud has severe microstuttering until the option "Disable Mailbox Presentation" is toggled, regardless of what it is set to. To my memory, the issues in Half Life are solved when this setting is set to enabled. Either way it seems like the microstuttering issues are tied to this option.

Reproduction Steps

Launch Dark Cloud and observe poor framepacing (i.e. by rotating the camera). Toggle the setting and the issues should go away.

Expected Behavior

There are no framepacing issues entirely - as is the case with 2.0.3

PCSX2 Revision

xbsx 2.0.7

Operating System

Windows 11

If Linux - Specify Distro

No response

CPU

xbox

GPU

xbox

GS Settings

No response

Emulation Settings

No response

GS Window Screenshots

No response

Logs & Dumps

No response

@therealteamplayer
Copy link
Author

therealteamplayer commented Jul 11, 2024

NOTE: originally I did not know much about the issue other than there being framepacing issues that were not present in 2.0.3, my earlier comments reflect this.

it might be an issue on my end I'll try and investigate some more

@therealteamplayer therealteamplayer closed this as not planned Won't fix, can't repro, duplicate, stale Jul 11, 2024
@therealteamplayer
Copy link
Author

therealteamplayer commented Jul 11, 2024

I can confirm that this build definitely has worse framepacing than older ones - however, the most severe framepacing issues went away once I enabled "Disable Mailbox Presentation", despite the option claiming it would make it worse.

@therealteamplayer
Copy link
Author

therealteamplayer commented Jul 11, 2024

Furthermore the result is inconsistent from game to game. Dark Cloud for instance has much better frame pacing with the option disabled, whereas Half-Life (with 300% overclock as the game lags on real hardware) is better with the option enabled.

edit: not sure what was causing the dodgy framepacinf in dark cloud now, cause jow it's working perfectly when I have the option enabled?

@therealteamplayer
Copy link
Author

Ok, even more strange. Dark cloud has horrendous frame pacing if I launch it after first starting the app, but if I then toggle the mailbox presentation setting, regardless of what it's set to, the frame pacing fixes its self?

@therealteamplayer
Copy link
Author

This is regardless of whether or not the no-interlacing patch is enabled, btw.

@therealteamplayer therealteamplayer changed the title [BUG]: 2.0.7 seemingly has microstutter [BUG]: 2.0.7 bad frame pacing until "Disable Mailbox Presentation" is toggled, regardless of what it is set to Jul 11, 2024
@therealteamplayer
Copy link
Author

Can confirm that the issue (at least with Dark Cloud) is present on 2.0.6 as well.

@therealteamplayer therealteamplayer changed the title [BUG]: 2.0.7 bad frame pacing until "Disable Mailbox Presentation" is toggled, regardless of what it is set to [BUG]: 2.0.7 bad frame pacing until either "Disable Mailbox Presentation" or "Enable Vsync" is toggled, regardless of what it is set to Jul 12, 2024
@therealteamplayer
Copy link
Author

therealteamplayer commented Jul 12, 2024

I'd make an issue on the mainline PCSX2 branch if i could replicate the problem on PC, but i've had no such luck...

at the very least, i've realised that turning vsync off and on again also removes the microstuttering once it occurs. And i've done a quick search in the code and narrowed the issue down i believe to pcsx2/VMManager.cpp, in the function VMManager::CheckForGSConfigChanges there's a check for whether either of VsyncEnable or DisableMailboxPresentation have changed, and if they have, it calls UpdateTargetSpeed(); and MTGS::UpdateVSyncMode();. so i'm assuming whatever these functions do fix the microstuttering. hopefully that's helpful to someone

@SternXD SternXD added the bug Something isn't working label Jul 13, 2024
@SternXD
Copy link
Member

SternXD commented Aug 27, 2024

Hello, I apologize for the delay in responding. I’m planning to release version 2.0.8.1 later today. Once it’s available, could you please try it on that build?

@therealteamplayer
Copy link
Author

therealteamplayer commented Sep 25, 2024

Sorry for the late reply - done some testing and frame pacing seems a lot better across the board with Sync to Host Refresh Rate and Optimal Frame Pacing both turned on. The issue specific to dark cloud seems fixed. Some games I've found benefit tremendously from having Disable Mailbox Presentation on - the previous version would crash when this was set on a per-game basis but thankfully this is no longer the case.

@therealteamplayer
Copy link
Author

therealteamplayer commented Sep 27, 2024

Actually, there is still a strange issue. It seems the formula is to have Sync to Host Refresh Rate and Optimal Frame Pacing turned on, with Disable Mailbox Presentation off globally but on in the per-game settings. Why this specific combination works for most games I've tested is unknown to me, but from my limited testing it seems any other configuration doesn't have great frame pacing.

Edit: I also have CDVD Precaching set to on, Allow Exclusive Full screen set to Force Disabled, Renderer set to Automatic, and Minimal Output Latency (in audio settings) set to On.

@therealteamplayer therealteamplayer changed the title [BUG]: 2.0.7 bad frame pacing until either "Disable Mailbox Presentation" or "Enable Vsync" is toggled, regardless of what it is set to [BUG]: Weird framepacing issues Sep 27, 2024
@SternXD
Copy link
Member

SternXD commented Dec 7, 2024

@therealteamplayer Alright so from what I've seen is a lot of things in upstream has changed regarding this. I am planning to release 2.0.8.2 this weekend (as you can tell that didn't happen I have no ETA at the moment but should be sometime soon) when that releases If you can retry this.

@SternXD SternXD added this to the 2.0.8.2 milestone Dec 7, 2024
@MCM1989
Copy link

MCM1989 commented Dec 22, 2024

I had poor frame pacing on 2.0.8.1 and 2.0.3. I reset my XBSX2 to the default settings and did not have the issue. I turned my preferred settings on one by one and found FXAA causes horrible frame pacing in every game. I turned it off and it pretty much went away. therealteamplayer I would check if FXAA is on and turn it off and see if that helps. I bet that FXAA is major cause of dropped frames / frame pacing issue in XBSX2. It took me forever to locate that as being the problem since on PC FXAA has no performance impact in the Nvidia control panel. I also tested max res the series S can maintain 60 fps in xbsx2 and the max res is 1080p internal. At 1440p on GT3 the frame rate started to dip. In conclusion if you want good framerates with good frame time pacing, do not turn on FXAA and do not exceed 1080p as the internal resolution.

@SternXD SternXD removed this from the 2.0.8.2 milestone Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants