From a72efe816aec1eef725563a69608c574595c0ccc Mon Sep 17 00:00:00 2001 From: ruizajtruss Date: Thu, 18 Apr 2024 16:36:55 +0000 Subject: [PATCH] more test fixes --- .../RateDetails/V2/RateDetailsV2.test.tsx | 13 +++++++------ .../RateDetails/V2/SingleRateFormFields.tsx | 1 + .../src/testHelpers/jestRateHelpers.tsx | 18 +++++++++++------- 3 files changed, 19 insertions(+), 13 deletions(-) diff --git a/services/app-web/src/pages/StateSubmission/RateDetails/V2/RateDetailsV2.test.tsx b/services/app-web/src/pages/StateSubmission/RateDetails/V2/RateDetailsV2.test.tsx index 1feacf7d9c..b8b2bc9c1e 100644 --- a/services/app-web/src/pages/StateSubmission/RateDetails/V2/RateDetailsV2.test.tsx +++ b/services/app-web/src/pages/StateSubmission/RateDetails/V2/RateDetailsV2.test.tsx @@ -940,21 +940,22 @@ describe('RateDetailsv2', () => { //Additional actuary contacts const contacts = screen.getAllByTestId('actuary-contact') - expect(contacts).toHaveLength(1) + expect(contacts).toHaveLength(2) //Adding another addtional actuary contact await user.click(addActuaryContact) const contactsPostClick = screen.getAllByTestId('actuary-contact') - expect(contactsPostClick).toHaveLength(2) + expect(contactsPostClick).toHaveLength(3) //Testing removal of actuary contact - const removeButtons = screen.getAllByText('Remove') - expect(removeButtons).toHaveLength(2) + const removeButtons = screen.getAllByTestId('removeContactBtn') + expect(removeButtons).toHaveLength(3) await user.click(removeButtons[0]) - const removeButtonsPostRemoval = screen.getAllByText('Remove') - expect(removeButtonsPostRemoval).toHaveLength(1) + const removeButtonsPostRemoval = + screen.getAllByTestId('removeContactBtn') + expect(removeButtonsPostRemoval).toHaveLength(2) }) }) }) diff --git a/services/app-web/src/pages/StateSubmission/RateDetails/V2/SingleRateFormFields.tsx b/services/app-web/src/pages/StateSubmission/RateDetails/V2/SingleRateFormFields.tsx index 56f9628ffe..ac53941fb5 100644 --- a/services/app-web/src/pages/StateSubmission/RateDetails/V2/SingleRateFormFields.tsx +++ b/services/app-web/src/pages/StateSubmission/RateDetails/V2/SingleRateFormFields.tsx @@ -533,6 +533,7 @@ export const SingleRateFormFields = ({ remove(index) setNewActuaryContactButtonFocus() }} + data-testid="removeContactBtn" > Remove diff --git a/services/app-web/src/testHelpers/jestRateHelpers.tsx b/services/app-web/src/testHelpers/jestRateHelpers.tsx index f870e19d03..cecdac8baa 100644 --- a/services/app-web/src/testHelpers/jestRateHelpers.tsx +++ b/services/app-web/src/testHelpers/jestRateHelpers.tsx @@ -75,11 +75,15 @@ const fillOutIndexRate = async (screen: Screen, index: number) => { expect( withinTargetRateCert.queryByText('Date certified') ).toBeInTheDocument() - expect(withinTargetRateCert.queryByText('Name')).toBeInTheDocument() expect( - withinTargetRateCert.queryByText('Title/Role') + withinTargetRateCert.queryAllByText('Name')[0] + ).toBeInTheDocument() + expect( + withinTargetRateCert.queryAllByText('Title/Role')[0] + ).toBeInTheDocument() + expect( + withinTargetRateCert.queryAllByText('Email')[0] ).toBeInTheDocument() - expect(withinTargetRateCert.queryByText('Email')).toBeInTheDocument() }) const startDateInputs = withinTargetRateCert.getAllByLabelText('Start date') @@ -93,16 +97,16 @@ const fillOutIndexRate = async (screen: Screen, index: number) => { await userEvent.paste('12/01/2021') // fill out actuary contact - withinTargetRateCert.getByLabelText('Name').focus() + withinTargetRateCert.getAllByLabelText('Name')[0].focus() await userEvent.paste(`Actuary Contact Person ${index}`) - withinTargetRateCert.getByLabelText('Title/Role').focus() + withinTargetRateCert.getAllByLabelText('Title/Role')[0].focus() await userEvent.paste(`Actuary Contact Title ${index}`) - withinTargetRateCert.getByLabelText('Email').focus() + withinTargetRateCert.getAllByLabelText('Email')[0].focus() await userEvent.paste(`actuarycontact${index}@test.com`) - await userEvent.click(withinTargetRateCert.getByLabelText('Mercer')) + await userEvent.click(withinTargetRateCert.getAllByLabelText('Mercer')[0]) } const rateCertifications = (screen: Screen) => {