New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remaining issues after prompt_toolkit migration #337

Closed

3 of 4 tasks

ErikBjare opened this issue Dec 15, 2024 · 1 comment

Closed

3 of 4 tasks

Remaining issues after prompt_toolkit migration #337

ErikBjare opened this issue Dec 15, 2024 · 1 comment

Owner

ErikBjare commented Dec 15, 2024 •

edited

Loading

Remaining after #244

Fix stdin support OSError: [Errno 22] Invalid argument, whenever getting input after PIPE in prompt-toolkit/python-prompt-toolkit#1943
- This seems to work, but not sure how reliable: Broken when piped to. prompt-toolkit/python-prompt-toolkit#502 (comment)
- Seemingly fixed by b3974c1
Fix buggy dir completion
- Should behave like fish
- Fixed in fix: fix log output during input, fix directory completion #338
https://github.com/prompt-toolkit/python-prompt-toolkit/blob/master/examples/prompts/patch-stdout.py
- Fixed in fix: fix log output during input, fix directory completion #338
- Would be really cool if we could let the user continue to write their next prompt while the assistant is thinking
  - For a future PR
  - How would interrupting the agent work then?
Make LLM-completions/suggestions work

The text was updated successfully, but these errors were encountered:

ErikBjare mentioned this issue

fix: fix log output during input, fix directory completion #338

Merged

ErikBjare added a commit that referenced this issue


          fix: fix reading stdin after prompt-toolkit migration (#337)

b3974c1

Owner Author

ErikBjare commented Dec 22, 2024

Closing this, LLM-completions will remain a semi-working TODO/FIXME in the code

ErikBjare closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment