From 75e0302d9f02ce07c26c6aa9853536a2918b9d48 Mon Sep 17 00:00:00 2001
From: JC Franco <jfranco@esri.com>
Date: Thu, 5 Oct 2023 16:11:51 -0700
Subject: [PATCH] fix(input-time-zone): fix handling of unknown and cityless
 time zones from offset display mode (#7947)

**Related Issue:** #7944

## Summary

This updates the component to remove cityless time zone entries in the
`offset` mode and for unknown entries (either from browser differences
or updated values) their city part will be displayed as is.

**Note**: due to time constraints, testing will be tackled in #7951.
---
 .../src/components/input-time-zone/utils.ts   | 78 +++++++++++++++++--
 1 file changed, 73 insertions(+), 5 deletions(-)

diff --git a/packages/calcite-components/src/components/input-time-zone/utils.ts b/packages/calcite-components/src/components/input-time-zone/utils.ts
index 3521bd384f9..b739a759d2c 100644
--- a/packages/calcite-components/src/components/input-time-zone/utils.ts
+++ b/packages/calcite-components/src/components/input-time-zone/utils.ts
@@ -4,6 +4,48 @@ import { InputTimeZoneMessages } from "./assets/input-time-zone/t9n";
 
 const hourToMinutes = 60;
 
+const timeZoneNameBlockList = [
+  "CET",
+  "CST6CDT",
+  "EET",
+  "EST",
+  "EST5EDT",
+  "Etc/GMT+1",
+  "Etc/GMT+10",
+  "Etc/GMT+11",
+  "Etc/GMT+12",
+  "Etc/GMT+2",
+  "Etc/GMT+3",
+  "Etc/GMT+4",
+  "Etc/GMT+5",
+  "Etc/GMT+6",
+  "Etc/GMT+7",
+  "Etc/GMT+8",
+  "Etc/GMT+9",
+  "Etc/GMT-1",
+  "Etc/GMT-10",
+  "Etc/GMT-11",
+  "Etc/GMT-12",
+  "Etc/GMT-13",
+  "Etc/GMT-14",
+  "Etc/GMT-2",
+  "Etc/GMT-3",
+  "Etc/GMT-4",
+  "Etc/GMT-5",
+  "Etc/GMT-6",
+  "Etc/GMT-7",
+  "Etc/GMT-8",
+  "Etc/GMT-9",
+  "Factory",
+  "HST",
+  "MET",
+  "MST",
+  "MST7MDT",
+  "PST8PDT",
+  "UTC",
+  "WET",
+];
+
 function timeZoneOffsetToDecimal(shortOffsetTimeZoneName: string): string {
   const minusSign = "−";
   const hyphen = "-";
@@ -71,16 +113,42 @@ export async function createTimeZoneItems(
 
       const listFormatter = new Intl.ListFormat(locale, { style: "long", type: "conjunction" });
 
+      // we remove blocked entries from tzs and adjust label indices accordingly
+      timeZoneGroups.forEach((group) => {
+        const indexOffsets: number[] = [];
+        let removedSoFar = 0;
+
+        group.tzs = group.tzs.filter((tz) => {
+          if (timeZoneNameBlockList.includes(tz)) {
+            removedSoFar++;
+            return false;
+          }
+
+          indexOffsets.push(removedSoFar);
+          return true;
+        });
+
+        group.labelTzIndices = group.labelTzIndices
+          .map((index) => index - (indexOffsets[index] || 0))
+          .filter((index) => index < group.tzs.length);
+      });
+
       return timeZoneGroups
         .map<TimeZoneItem<number>>(({ labelTzIndices, tzs }) => {
           const groupRepTz = tzs[0];
           const decimalOffset = timeZoneOffsetToDecimal(getTimeZoneShortOffset(groupRepTz, locale, referenceDateInMs));
           const value = toOffsetValue(groupRepTz, referenceDateInMs);
-          const label = createTimeZoneOffsetLabel(
-            messages,
-            decimalOffset,
-            listFormatter.format(labelTzIndices.map((index: number) => messages[tzs[index]]))
-          );
+          const tzLabels = labelTzIndices.map((index: number) => {
+            const timeZone = tzs[index];
+            const timeZoneLabel = messages[timeZone];
+            return (
+              timeZoneLabel ||
+              // get city token
+              timeZone.split("/").pop()
+            );
+          });
+
+          const label = createTimeZoneOffsetLabel(messages, decimalOffset, listFormatter.format(tzLabels));
 
           return {
             label,