Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Carousel] Animation does not display when autoplay advances #11317

Closed
2 of 6 tasks
macandcheese opened this issue Jan 16, 2025 · 2 comments
Closed
2 of 6 tasks

[Carousel] Animation does not display when autoplay advances #11317

macandcheese opened this issue Jan 16, 2025 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-carousel Issues that pertain to the calcite-carousel component Calcite (design) Issues logged by Calcite designers. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2025-02-06 - 3.0....

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Actual Behavior

When the Carousel component has autoplay enabled, and the component advances to the next Carousel Item - no animation is displayed.

Expected Behavior

I'd expect the animation to display anytime the Carousel Item changes. This should match the animation used for mouse or keyboard Carousel Item changes.

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/GgKGYba?editors=100

Reproduction Steps

  1. Navigate to Codepen
  2. Notice that when the autoplay functionality advances, no animation is shown.
  3. Interact with the Carousel and changes slides with mouse, or keyboard.
  4. See expected aniamtion

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

No

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-carousel Issues that pertain to the calcite-carousel component estimate - 2 Small fix or update, may require updates to tests. needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library labels Jan 16, 2025
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 16, 2025
@macandcheese macandcheese mentioned this issue Jan 18, 2025
Merged
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Jan 18, 2025
@macandcheese macandcheese self-assigned this Jan 18, 2025
@macandcheese macandcheese added estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. and removed needs triage Planning workflow - pending design/dev review. estimate - 2 Small fix or update, may require updates to tests. labels Jan 18, 2025
macandcheese added a commit that referenced this issue Jan 23, 2025
@macandcheese
fix(carousel): Ensure correct autoplay display and animation (#11338)
a5626fa 
**Related Issue:** #11317 

## Summary
Ensures the animation is correctly applied when `autoplay` advances
through Carousel Items.
Also updates the Progress component to adhere to the new `value` format
/ breaking change for 3.x:
#10622 / logged in
internal tracking discussion
@macandcheese macandcheese added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Jan 23, 2025
@github-actions github-actions bot removed the 2 - in development Issues that are actively being worked on. label Jan 23, 2025
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned macandcheese Jan 23, 2025
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 27, 2025
@geospatialem
Copy link
Member

Verified in 3.0.0-next.113 ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-carousel Issues that pertain to the calcite-carousel component Calcite (design) Issues logged by Calcite designers. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2025-02-06 - 3.0.0 Feb Breaking Chang...
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP