Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor isHidden Function #11361

Open
1 of 5 tasks
josercarcamo opened this issue Jan 22, 2025 · 0 comments
Open
1 of 5 tasks

Refactor isHidden Function #11361

josercarcamo opened this issue Jan 22, 2025 · 0 comments
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@josercarcamo
Copy link
Contributor

josercarcamo commented Jan 22, 2025 •
edited
Loading

Description

Refactor the user of the isHidden function into a controller so that it is no longer a utility function.

Proposed Advantages

Smaller utility library and less includes.

Which Component

Combobox, Stepper, and Table.

Relevant Info

https://github.com/Esri/calcite-design-system/pull/10983/files/7da4daa7fe126e6d61bc8380183b7259afaa9775#diff-09020688df3a3da0a6975306539e0b6a5964c698e8c4b0a4ed90b450f85ce2ac

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@josercarcamo josercarcamo added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked. labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josercarcamo