Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree items with icons appear misaligned #6508

Closed
nwhittaker opened this issue Feb 23, 2023 · 2 comments
Closed

Tree items with icons appear misaligned #6508

nwhittaker opened this issue Feb 23, 2023 · 2 comments
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. c-tree Issues that pertain to the calcite-tree and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review.

Comments

@nwhittaker
Copy link
Contributor

Actual Behavior

The leading edges of the tree-items' icons are not aligned with the leading edges of their siblings:

Screenshot 2023-02-23 at 11 25 35 AM

Expected Behavior

The leading edges of the tree-items' icons are aligned with the leading edges of their siblings:

Screenshot 2023-02-23 at 11 34 13 AM

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/VwGjyvZ

Reproduction Steps

  1. Visit repro sample and expand tree items

Reproduction Version

1.0.7

Relevant Info

The .icon-start element is applying a margin-inline style, but it should probably be a margin-inline-end style instead.

Regression?

No response

Impact

The misalignment doesn't look great, plus the Field Maps web app has a tree in a resizable panel -- so the extra space further constrains the usable width.

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Feb 23, 2023
@github-actions github-actions bot added the ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. label Feb 23, 2023
@geospatialem geospatialem added design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Apr 18, 2023
@geospatialem
Copy link
Member

Consideration for enhancement should be routed through designers for next steps.

@geospatialem geospatialem added the c-tree Issues that pertain to the calcite-tree and related components label Jun 15, 2023
@geospatialem
Copy link
Member

Closing in favor of #7096

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. c-tree Issues that pertain to the calcite-tree and related components design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nwhittaker @alisonailea @geospatialem