Linear Line of Sight produces no results if data frame coordinate system is changed in a session

[BobBooth]

Doing checklist testing, I added the released Visibility Add-In (http://appsforms.esri.com/products/download/index.cfm?fuseaction=download.main&downloadid=2015) to the latest ArcMap 10.6 (8319).
I added SRTM 30 m data for the AOI from Military Tools test data. That raster is in GCS_WGS_1984
I attempted to use the Visibility LLOS tool on the data, but got the warning that it was not projected.
I changed the data frame coordinate system to World Mercator (linear units meters) and exported a copy of the raster in that, added it, used it as elevation source.
I can add points, but I do not see them (neither observers nor targets).
I can click OK to run the tool, and the data frame pans, but I see no results.

RLOS does work.

[BobBooth]

@lfunkhouser @topowright @csmoore

[csmoore]

@BobBooth - I seem to be able to reproduce this with some difficulty. It seems to be related to the step of actually changing the projection of the data frame. When this happens, none of the addins seems to be able to add graphics to the graphics container (though all other processing behaves as normal - you just can't see it).

Here were my repro steps (10.6.8271):

1. Launch ArcMap
2. Add a local basemap: C:\Program Files (x86)\ArcGIS\Desktop10.6\TemplateData\TemplateData.gdb\World\continent
3. Add the elevation dataset from Military Tools Geoprocessing:
   military-tools-geoprocessing-toolbox-dev\testdata\MilitaryToolsTestData.gdb\ElevationUTM_Zone10
4. Set the data frame to be in the same projection/SR as ElevationUTM_Zone10
5. Use one of the military tools addin map tools to drop a marker or line
6. None of the addins seem to be able to drop marker/line graphics - though all other processing behaves as normal
   a. All of the addins use very similar code - so it is possible that this is a bug there with a reproject or something

Update: these steps work as expected on 10.4.1 so seems to be something specific to 10.6

[BobBooth]

@csmoore - thanks for narrowing it down - I confirm that is has to do with changing the data frame projection. I can use the same UTM-projected elevation data and the tool works, if I just add the projected data to the map.

[BobBooth]

@csmoore - updated the title.

[csmoore]

This seems to be a GraphicsContainer bug at 10.6. I can reproduce this same issue with the Graphics Container SDK sample :

1. Launch ArcMap
2. Add a local basemap: C:\Program Files (x86)\ArcGIS\Desktop10.6\TemplateData\TemplateData.gdb\World\continent
3. Set the Data Frame coordinate system to Projected | WGS 1984 Web Mercator (aux sphere)
4. Use the "Dharma Toolbar" from the SDK Custom UI elements sample to draw a line
5. Line does not draw after being added to GraphicsContainer
   a. Note: if you draw the line big enough (size of US) you can see a much bigger mis-projected line
6. A prebuilt version of the addin from this SDK sample is at: https://esri.box.com/s/0x8dmuojp0i3kdcyn7qlot12enwn9xft

@lfunkhouser @topowright - can we report this issue?

[lfunkhouser]

@ACueva please work with @csmoore to understand and follow up with this issue ASAP.

[ACueva]

Spoke with POC: David B.

The feedback I received can be summed up to "Why are you running LOS on the world?".

@csmoore @BobBooth We need to test this further to see if what we actually encountered is more of a work-flow issue. The part that does concern me is if bad values are entered, the behavior should not be that you can't do anything else with our tools.

Let's touch base on Monday to see if we can get a more detailed workflow, including exact projections used. Also, we need to try to reproduce this on a previous version to see if this has always been an issue or something introduced at this release.

[BobBooth]

This is a bug with 10.6 that is not present when using the Visibility Add-In with 10.3.1 (available on the test VM I had).
Steps to repro:
Add test data (n36.dt2) from solutions GP tools (military-tools-geoprocessing-toolbox/tree/dev/testdata/Elevation/Source/SRTM30M)

The add-in gives "Please project your data" message.
The data was in WGS84:

Change data frame to UTM Z 11 N

Export raster with same projection as data frame (UTM).
Switch Visibility pane to using the projected (UTM) raster.
Tool works as expected:

In contrast, with 10.6, the data frame and elevation source can be set to UTM and the tool will add points, but you can't see them on the map. Run the tool, it seems to run, but no output is displayed.

[BobBooth]

@ACueva your POC missed the point.
Not running it on the world.

[topowright-zz]

@ACueva I think the person you spoke with is David Burrows

[csmoore]

The main point we wanted to make to them is that this same issue is present using the SDK sample if we change the map projection - detailed steps with the ArcObjects SDK sample are above

[topowright-zz]

I am not able to reproduce this issue at 10.6 build 8321. My steps to check this issue is:

1. Install the Visibility Add-In
2. Add the button to a toolbar
3. Open the add-in
4. Add the SRTM30 - n36.dt2 from the source testing folder
5. Drop points on the map
6. Attempt to run
7. Result: Your data is not projected
8. Remove the layer and add in the projected UTM Zone 10 layer from the Military Tools geodatabase
9. Remove the points in the LLOS tool
10. Attempt to run
11. Result: Your data frame is not projected
12. Reproject my data frame into UTM Zone10 projection
13. Remove the graphics in LLOS tool
14. Add more graphics
15. Attempt to run the tool
16. Good results

[topowright-zz]

I would like to run thru this workflow with you @BobBooth and see your workflow as well. Moving this to verify

[topowright-zz]

@BobBooth I just saw your comments that you cannot replicate this with 10.3.1 and I can no longer replicate this issue with 0.6 build 8321. I think this should be closed.

[BobBooth]

@topowright - It is non-repro on 10.3.1, but it is definitely still a problem on 10.6 (just installed 8321, and it is failing in exactly the same way).
Steps to repro:

1. Add the n36.dt2 raster to the map. (data frame will be set to GCS_WGS_84)
2. Add observer and target points.
3. attempt to run - get "please project" message.
4. Set the data frame coord system to a projected one (I used NAD_1983_UTM_Zone_11N)
5. Export the n36.dt2 layer using the data frame's coordinate system, add the results to the map.
6. Switch the Input Surface to the projected raster.
7. Click Cancel (clears input points)
8. Click Clear Graphics (clears graphics)
9. Add observer and target points. Note that they do not display, but they are added to the points lists in the Visibility window.
10. Click OK.
    The display zooms to the extent of the points you dropped, but no results show up, nor do the points you dropped.

@topowright @csmoore

[topowright-zz]

It is also a issue on 10.5.1. I am going to double check on 10.3.1

[topowright-zz]

I have double checked this exact workflow that @BobBooth found in 10.3.1 and it works just fine. Reaching out to the core person who deals with projections was not sure what this issue was. I have sent a issue to the sp-arcmap and I am waiting to see what comes of it.

[csmoore]

@topowright - I added the location of the prebuilt SDK sample/addin to the SDK sample repro steps above

[csmoore]

The good news is the underlying SDK issue seems to be fixed at 10.7.1, so this should now work at that version.

The bad news is that I noticed at 10.6.1 that the issue was much worse and showed up even if you opened an .mxd with a reprojected map (before if you saved the mxd and restarted ArcMap things would work)

[lfunkhouser]

Versions are not fully understood on this issue. From the comments in this issue, seems like it was a problem at 10.5.1, 10.6 and 10.6.1. What about 10.7, 10.5, 10.4.1, 10.4?
Adding QC label to determine what versions of ArcMap we are experiencing this issue. This affects documentation. Adding Doc labels.

[csmoore]

If it helps, I know that this was a problem from 10.4.1 to 10.6.1 - the only version I am not sure about is whether it was fixed at 10.7 or 10.7.1

[dfoll]

update known issue to list what versions it is broken at, then move back to product backlog

[dfoll]

@lfunkhouser @csmoore I have tried several times to read and understand the comments on this issue. I feel that this issue has grown too unruly and difficult to easily diagnose and fix the problem. It seems that there was more going on with this issue that the SDK issue that was fixed at 10.7.1 as this problem is still happening. I would like to close this issue in favor #327

[lfunkhouser]

@dfoll I think it is a problem that was introduced at 10.4, present at 10.5 and 10.6. It worked at 10.3.1, and worked again at 10.7/10.7.1. I don't want to close but rather investigate it as a team. I think the steps to reproduce are clear, the back and forth was just on the versions as I understand it.

[dfoll]

@lfunkhouser sounds good. when we do look at this, i think we are just going to end up closing a few of them at one time as duplicates

[csmoore]

This is a repeat of #327 - #327 issue was updated to cover the additional case mentioned here where Visibility Add Point Tool does not add points after the Coordinate System is changed.

The comment here covers the ArcMap versions that the problem is encountered / fixed on:
#327 (comment)