From 399b7fca8cd372b95fc4bbb2d94a4db0073c0c08 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9rgio=20Silveira?= Date: Wed, 15 May 2024 10:19:41 +0200 Subject: [PATCH] fixed visibility of some methods on the plugin class --- src/EventStore.Plugins/Plugin.cs | 6 +++--- .../Diagnostics/PluginMetricsTests.cs | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/EventStore.Plugins/Plugin.cs b/src/EventStore.Plugins/Plugin.cs index c73452b..bc83d84 100644 --- a/src/EventStore.Plugins/Plugin.cs +++ b/src/EventStore.Plugins/Plugin.cs @@ -78,11 +78,11 @@ protected Plugin(PluginOptions options) : this( /// public bool Enabled => IsEnabledResult.Enabled; - public virtual void ConfigureServices(IServiceCollection services, IConfiguration configuration) { } + protected virtual void ConfigureServices(IServiceCollection services, IConfiguration configuration) { } - public virtual void ConfigureApplication(IApplicationBuilder app, IConfiguration configuration) { } + protected virtual void ConfigureApplication(IApplicationBuilder app, IConfiguration configuration) { } - public virtual (bool Enabled, string EnableInstructions) IsEnabled(IConfiguration configuration) => (true, ""); + protected virtual (bool Enabled, string EnableInstructions) IsEnabled(IConfiguration configuration) => (true, ""); IServiceCollection IPlugableComponent.ConfigureServices(IServiceCollection services, IConfiguration configuration) { Configuration = configuration; diff --git a/test/EventStore.Plugins.Tests/Diagnostics/PluginMetricsTests.cs b/test/EventStore.Plugins.Tests/Diagnostics/PluginMetricsTests.cs index 2830396..56af130 100644 --- a/test/EventStore.Plugins.Tests/Diagnostics/PluginMetricsTests.cs +++ b/test/EventStore.Plugins.Tests/Diagnostics/PluginMetricsTests.cs @@ -40,7 +40,7 @@ public void can_receive_metrics_from_plugin() { class AdamSmasherPlugin(params KeyValuePair[] diagnosticsTags) : Plugin(diagnosticsTags: diagnosticsTags) { public Counter TestCounter { get; private set; } = null!; - public override void ConfigureApplication(IApplicationBuilder app, IConfiguration configuration) { + protected override void ConfigureApplication(IApplicationBuilder app, IConfiguration configuration) { var meterFactory = app.ApplicationServices.GetRequiredService(); var meter = meterFactory.Create(DiagnosticsName, Version, DiagnosticsTags);