Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Better manialink controller error handling #310

Open
araszka opened this issue Oct 4, 2024 · 0 comments
Open

[BUG] Better manialink controller error handling #310

araszka opened this issue Oct 4, 2024 · 0 comments
Labels
bug Something isn't working core Issue or feature request related to the core code.

Comments

@araszka
Copy link
Member

araszka commented Oct 4, 2024

Describe the bug
If InvalidOperationException is thrown during the execution of a manialink controller action, the server controller is going to log a missleading No action found for route '...' error message.

To Reproduce
Steps to reproduce the behavior:

  1. Create a manialink controller and a action to call
  2. Throw a InvalidOperationException in the code
  3. Trigger the manialink controller action

Expected behavior
The server controller checks for the existence of the action and does not soley rely on the InvalidOperationException class to determine whether an action was found.

@araszka araszka added bug Something isn't working chat commands Issues related to the chat command system. and removed chat commands Issues related to the chat command system. labels Oct 4, 2024
@snixtho snixtho added the core Issue or feature request related to the core code. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working core Issue or feature request related to the core code.
Projects
None yet
Development

No branches or pull requests

2 participants