Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding arrival_time to flights model #16

Open
tomduggan85 opened this issue Jul 25, 2018 · 2 comments
Open

Consider adding arrival_time to flights model #16

tomduggan85 opened this issue Jul 25, 2018 · 2 comments

Comments

@tomduggan85
Copy link

It might be helpful to include an arrival_time field for flights. Knowing departure_time and arrival_time, you could then calculate the flight duration whenever you needed to display it to the user.

@amusameh
Copy link
Collaborator

great, I added arrival_time and deleted flight time(meant to be duration).
@tomduggan85 I made a pull request that fixes all the issues.

I believe it's a great learning chance for us having a senior developer guiding us, so we are looking forward to hearing more from you as the project progress in any aspects and anywhere there is a room for improvement also any suggestions that will make us a better developers are very welcome as they say (Good is the Enemy of Great)

Thanks a million

@tomduggan85
Copy link
Author

You're welcome! I'll try to help in any way that I can. And please, feel free to send me a message any time and ask me anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants