Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iPad Layouts #61

Open
namsnath opened this issue Jan 19, 2020 · 9 comments
Open

Fix iPad Layouts #61

namsnath opened this issue Jan 19, 2020 · 9 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest 2020!

Comments

@namsnath
Copy link
Collaborator

namsnath commented Jan 19, 2020

The layout of the app does not look good on iPads in portrait mode (768x1024 px).
This could be fixed by making the CourseSelection component wider and the SlotTable narrower, and changing the column count for it.
The Navbar also needs editing. A possible solution would be to allow it to collapse into a hamburger menu like on mobile screens.
image

The Timetable component also overflows. It could be made to split into two parts like on Mobile Screens (eg: 360x740 px).
This should be a quick fix by changing the media query here:

<MediaQuery minDeviceWidth={768}>

The timetable component on mobile screens:
image

@namsnath namsnath added the bug Something isn't working label Apr 16, 2020
@roerohan roerohan added the hacktoberfest Hacktoberfest 2020! label Oct 1, 2020
@namsnath namsnath added the good first issue Good for newcomers label Oct 1, 2020
@swapnalshahil
Copy link

Hey, can you post issue ss, please?

@namsnath
Copy link
Collaborator Author

namsnath commented Oct 2, 2020

Hey there, my bad. I'll add screenshots to the original comment.

@namsnath
Copy link
Collaborator Author

namsnath commented Oct 2, 2020

Added screenshots and additional information.

@namsnath
Copy link
Collaborator Author

namsnath commented Oct 2, 2020

Hey @swapnalshahil , do you want to pick this up? Should I assign it to you?

@IzacVrushabh
Copy link

If no one is assigned , can you assign this issue to me ?

@namsnath
Copy link
Collaborator Author

namsnath commented Oct 2, 2020

Sure @IzacVrushabh !
I'll assign this to you.

@namsnath
Copy link
Collaborator Author

namsnath commented Oct 9, 2020

Hey @IzacVrushabh , any updates on this?

@IzacVrushabh
Copy link

Hey @IzacVrushabh , any updates on this?

I'm getting some problems with installation . I am unassigning myself so others can work on it.

@IzacVrushabh IzacVrushabh removed their assignment Oct 9, 2020
@namsnath
Copy link
Collaborator Author

namsnath commented Oct 9, 2020

Oh alright

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Hacktoberfest 2020!
Projects
None yet
Development

No branches or pull requests

4 participants