Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose pure functions #29

Open
joeblau opened this issue Oct 6, 2022 · 0 comments
Open

Expose pure functions #29

joeblau opened this issue Oct 6, 2022 · 0 comments

Comments

@joeblau
Copy link

joeblau commented Oct 6, 2022

There are a few pure functions without side effects that are private. I'm not sure why, but it makes building UI's a lot harder because you have to re-build the internal calculations.

Here are the list of pure functions that should be exposed

  • _calculateMintReward
  • _calculateStakeReward

The proposal is to copy the pattern the get function.
getMintReward
getStakeReward
@joeblau joeblau changed the title Expose pure functions. Expose pure functions Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeblau