Zigbrain slows down the intellij terminal

[borissmidt]

Dear,

After profiling my IDE i've noticed that ZigBrains slows down the terminal.
It seems every call to jediterm.ProcessChar ends up as a call to:

ZigBrains/core/src/main/kotlin/com/falsepattern/zigbrains/project/console/ZigSourceFileFilter.kt

Line 41 in adb8797

override fun applyFilter(line: String, entireLength: Int): Filter.Result? {

To profile this issue, i catted a long file and ran the async profiler it also seems that because the file has many lines like :01:14:27,570 it triggers the findLongestParseablePathFromOffset which then always fails on the file exists.

Maybe it could be useful the file.NonExists seems to be the slowest.

profile.zip

It might be better to work like the intellij plugin of the console and highlight it even if it isn't an existing file.
The user will than get a false positive underlining without any real disadvantage.

[borissmidt]

I tried it with another file and then the performance is less affected it still contributes to 4% of the cpu usage.
But maybe there is just a bigger issue with the design of the terminal itself that it works on a per character level.
So it makes way to many calls to the filter.

[FalsePattern]

Fixed in 20.1.2

I also did some before/after low-precision profiles when doing cat Down_House_2001_eng.srt in the terminal:

Before:

After:

[borissmidt]

Cool, i've also spend some time for this one:

I suspect because the build interminal passes one character at a time it really calls these code path too often. I think it xan be resolved by passing a buffer in one go.

So i opened an issue here about it and i'll see how they will respond.
JetBrains/jediterm#294

Tanks again for resolving this issue.