Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type hints for public interface? #50

Open
sh-at-cs opened this issue Jan 10, 2024 · 1 comment · May be fixed by #58
Open

Type hints for public interface? #50

sh-at-cs opened this issue Jan 10, 2024 · 1 comment · May be fixed by #58

Comments

@sh-at-cs
Copy link

Thanks for the really useful library!

It would be even better if it came with type annotations for its public interface (i.e. just mjml_to_html, as far as I can tell) and a py.typed marker to allow dependent projects to type check their usage of the library.

@FelixSchwarz
Copy link
Owner

I'll try to add some type hints. I need to check the py.typed marker which I did not use so far.

This was referenced Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants