This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

Variable name suggestion #74

Open

nsmedira opened this issue Mar 10, 2022 · 0 comments

Collaborator

nsmedira commented Mar 10, 2022

Solon/src/components/Pagination.jsx

Lines 25 to 28 in ac30a1c

    
           let cp = currentPage; 
        
           let begin = cp < half ? 0 : cp - half; 
        
           let end = cp < half ? perPage : cp + (half - 1);

IMO copying currentPage into cp reduces readability. could we not simply use currentPage where we are using cp?

This issue prompted by this discussion.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.