Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Trace use HEX representation for parameter values ​​of types [VAR]CHAR CHARACTER SET OCTETS and [VAR]BINARY #8356

Closed
pbhofstede2 opened this issue Dec 20, 2024 · 2 comments · Fixed by #8399

Comments

@pbhofstede2
Copy link

From firebird support list: https://groups.google.com/u/2/g/firebird-support/c/kPgAW-BtpQo

When tracing, parameters are logged, very nice.
Currently we use CHAR(16) CHARACTER SET OCTETS to store ID-values.

Tracing log them like this.
param0 = varchar(16), " ßFÃ/¿J¹Z3¡õñ]["

I can manually convert this to hex by Win1252 decoding, (DF46C32FBF4AB95A33A1F5F15D5B) but it would be much easier to have a Hex presentation when parameter is of Octets charset.
Please implement encoding with hex-values when parameter is of type CHAR(16) CHARACTER SET OCTETS.

@pbhofstede2 pbhofstede2 changed the title Firebird 5.0 Trace, parameter logging [improvement] Firebird 5.0 Trace, parameter logging Dec 20, 2024
@hvlad hvlad self-assigned this Dec 20, 2024
@hvlad hvlad changed the title [improvement] Firebird 5.0 Trace, parameter logging Make Trace use HEX representation for parameter values ​​of types [VAR]CHAR CHARACTER SET OCTETS and [VAR]BINARY Jan 17, 2025
hvlad added a commit that referenced this issue Jan 17, 2025
…alues ​​of types [VAR]CHAR CHARACTER SET OCTETS and [VAR]BINARY.
hvlad added a commit that referenced this issue Jan 20, 2025
Improvement #8356 : Make Trace use HEX representation for parameter values ​​of types [VAR]CHAR CHARACTER SET OCTETS and [VAR]BINARY.
hvlad added a commit that referenced this issue Jan 21, 2025
…alues ​​of types [VAR]CHAR CHARACTER SET OCTETS and [VAR]BINARY.
@pbhofstede2
Copy link
Author

Thanks for the quick improvement Vlad!
I can confirm the snapshot build shows me the parameters like CHAR(16) OCTETS now like
param0 = varbinary(16), "3DFD41B2DD17481A9A8D4AB76464DAA3"
which are much better to analyze.

@hvlad
Copy link
Member

hvlad commented Jan 22, 2025

Thanks for feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment