Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary reload of the encryption plugin in the Super architecture #8389

Open
MochalovAlexey opened this issue Jan 14, 2025 · 0 comments
Open

Comments

@MochalovAlexey
Copy link
Contributor

Hello, colleagues,

During the debugging of my encryption plugin, I identified an unnecessary reload of the encryption plugin in CryptoManager::lockAndReadHeader() (CryptoManager.cpp) for the Super architecture. This reload was unintentionally introduced by me in PR #7423. It can result in the plugin's key being overwritten during its operation, as occurred in my case.

This issue is primarily related to the specific implementation of my plugin and should not affect other plugins if they securely manage their keys and prevent spontaneous changes during encryption or decryption processes. However, for the Super architecture, this reload is redundant—it simply reloads the same plugin with the same key, serving no useful purpose. For this reason, I have decided to address it.

The reload is only required for the Classic architecture when the encryption state is modified from another process after an AST trigger.

This issue affects all major versions: 3, 4, 5, and 6. A PR with the fix will be provided shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant