Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of assimilations #203

Open
7 tasks done
robinschwab opened this issue Jan 14, 2025 · 5 comments
Open
7 tasks done

Sorting of assimilations #203

robinschwab opened this issue Jan 14, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@robinschwab
Copy link

robinschwab commented Jan 14, 2025

Checklist

  • I can reproduce the bug with the latest version given here.
  • I made sure that there are no existing issues - open or closed - to which I could contribute my information.
  • I made sure that there are no existing discussions - open or closed - to which I could contribute my information.
  • I have read the FAQs inside the app (Menu -> About -> FAQs) and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected app version

1.1.0

Affected Android/Custom ROM version

Android 15 / GrapheneOS

Affected device model

Pixel 6

How did you install the app?

F-Droid / IzzyOnDroid

Steps to reproduce the bug

Create contacts with names that contain assimilations (i.e. ÄÖÜ in German), display them in the contacts list.

I.e.: Hans Äberhart, Hans Aeberhart, Hans Adler

On (american) keyboards that do not contain these special characters you type Ae instead of Ä.

Expected behavior

  • Äberhard, Hans
  • Aeberhard, Hans
  • Adler, Hans

Actual behavior

  • Äberhard, Hans
  • Adler, Hans
  • Aeberhard, Hans

Screenshots/Screen recordings

Sorting

Additional information

The above list is trivial so you might think it is not a real problem. But imagine a long list with many names beginning with from Ab..., to Ap: The two identical names will show up several screens apart in the list.

@robinschwab robinschwab added bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 14, 2025
@Aga-C Aga-C added enhancement New feature or request and removed bug Something is not working needs triage Issue is not yet ready for PR authors to take up labels Jan 14, 2025
@Aga-C
Copy link
Member

Aga-C commented Jan 14, 2025

It should be done more thoroughly. Generally, we should consider the fact, that in different locales there are different sorting rules. I suppose we're using international collation, while we should use a proper one for Android's current locale (not UI language).

@robinschwab
Copy link
Author

I can confirm that affected users will consider the present state a bug.

@chesio
Copy link

chesio commented Jan 14, 2025

@robinschwab I understand your request, but is your example of "actual behavior" correct? I don't think Aeppli would ever get sorted before Adler using general collation rules...

@robinschwab
Copy link
Author

@robinschwab I understand your request, but is your example of "actual behavior" correct? I don't think Aeppli would ever get sorted before Adler using general collation rules...

You are correct. If you use Äberhard/Aeberhard instead the example works. I edited my issue.

@robinschwab
Copy link
Author

robinschwab commented Jan 14, 2025

Here is a French example.
Sorting French

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants