From 602ef11f74bd8ca69c13ec957fe7cedb41d71ea7 Mon Sep 17 00:00:00 2001 From: Dave Slager Date: Tue, 29 Oct 2024 09:56:44 -0700 Subject: [PATCH 1/4] clean up invalid default ORCID generated by usethis --- R/create_visc_project.R | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/R/create_visc_project.R b/R/create_visc_project.R index 44a48671..a947a1a9 100644 --- a/R/create_visc_project.R +++ b/R/create_visc_project.R @@ -33,7 +33,15 @@ create_visc_project <- function(path, interactive = TRUE){ usethis::create_package( path = path, rstudio = TRUE, - open = interactive + open = interactive, + # fields override for usethis 3.0.0 ORCID placeholder, errors out in R 4.5 + # https://github.com/r-lib/usethis/issues/2059 + fields = list( + `Authors@R` = paste0( + "person(\"First\", \"Last\", email = \"first.last", + "@example.com\", role = c(\"aut\", \"cre\"))" + ) + ) ) # must set active project otherwise it is From 7babeaf7b7af53f496f191a3adbf36903988a6e0 Mon Sep 17 00:00:00 2001 From: Dave Slager Date: Tue, 29 Oct 2024 09:58:31 -0700 Subject: [PATCH 2/4] document() whitespace --- man/use_visc_methods.Rd | 1 - 1 file changed, 1 deletion(-) diff --git a/man/use_visc_methods.Rd b/man/use_visc_methods.Rd index 07c4a937..7b059b9d 100644 --- a/man/use_visc_methods.Rd +++ b/man/use_visc_methods.Rd @@ -17,7 +17,6 @@ use_visc_methods( \item{interactive}{TRUE by default. FALSE is for non-interactive unit testing only.} - } \description{ Creates a "methods" directory that contains 3 "child" R Markdown documents From 7467986ff1d6708c14f52c0173a0c6675af981d6 Mon Sep 17 00:00:00 2001 From: Dave Slager Date: Tue, 29 Oct 2024 10:03:29 -0700 Subject: [PATCH 3/4] clearer wording --- R/create_visc_project.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/R/create_visc_project.R b/R/create_visc_project.R index a947a1a9..15699ae2 100644 --- a/R/create_visc_project.R +++ b/R/create_visc_project.R @@ -34,7 +34,7 @@ create_visc_project <- function(path, interactive = TRUE){ path = path, rstudio = TRUE, open = interactive, - # fields override for usethis 3.0.0 ORCID placeholder, errors out in R 4.5 + # fields override for usethis 3.0.0 ORCID placeholder that errored in R 4.5 # https://github.com/r-lib/usethis/issues/2059 fields = list( `Authors@R` = paste0( From 2cf97a98adde488d7ca13b1f6e97260215f2e586 Mon Sep 17 00:00:00 2001 From: Dave Slager Date: Tue, 29 Oct 2024 10:41:08 -0700 Subject: [PATCH 4/4] news update --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index 763cac52..a948f587 100644 --- a/NEWS.md +++ b/NEWS.md @@ -3,6 +3,7 @@ Bug fixes * Provide default CRAN mirror if missing in install_load_cran_packages(), e.g., in a child R session during knitting. Fixes 'trying to use CRAN without setting a mirror' error (#218) * Update template.tex so that flextable package can be used to create tables in PDF documents (#226) +* Clean up invalid ORCID placeholder generated by usethis 3.0.0 that threw error on R version 4.5.x (#248) Other improvements * create_visc_project() now discards README.Rmd after knitting template to README.md (#223)