-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependencies #21
Comments
@nicolopignatelli if you agree we might just copy as few classes as possible from valueobjects to this project moving to the right namespaces |
that, or just code the minimum needed to accomplish whatever we want here |
thanks for looking into this :) |
did a couple of spike, but it's not that easy to do keeping the bar green, I will give another try next weekend |
sorry for postponing again |
done with dependency removal, |
Cool! thanks for your work :D #23 sounds nasty |
nicolopignatelli/valueobjects
has some requirements that just don't really make any sense likemathiasverraes/money
(which is afaik, an example implementation for VOs).Additionally the Enum thing is not supported by PHPStorm. I'd like deprecate that for simple constants. With that we would only have a dependency to guzzle. Then use
rhumsaa/uuid
directly for UUID generation.Not saying that the valueobjects package is bad btw! Just a lot of unnecessary dependencies :)
If you guys agree I'd provide a PR soonish.
The text was updated successfully, but these errors were encountered: