Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@frigade/react: add React 19 support #408

Open
Kiryous opened this issue Dec 25, 2024 · 3 comments
Open

@frigade/react: add React 19 support #408

Kiryous opened this issue Dec 25, 2024 · 3 comments

Comments

@Kiryous
Copy link

Kiryous commented Dec 25, 2024

While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"19.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17 - 18" from @frigade/[email protected]
npm ERR! node_modules/@frigade/react
npm ERR!   @frigade/react@"^2.6.7" from the root project
@christianmat
Copy link
Contributor

Hi @Kiryous, could you possibly share your package.json with us and the command that results in the error you attached?

Our open-source demo runs the same version (see demo and source code here: https://demo.frigade.com), but I am not able to reproduce the above error however.

@caitlin-orb
Copy link

Hi,
I ran into this error as well when installing the @frigade/react package when using react 19. The installation works perfectly fine when an app targets react 18.

It looks like the frigade demo and source code is currently targeting react 18 so it doesn't and wouldn't run into the installation error.
https://github.com/FrigadeHQ/demo/blob/e206f6c636fb905e1b75feb29968b697404171a9/package.json#L32

You can reproduce the error by trying to upgrade the frigade demo app to use react 19.

npm error While resolving: [email protected]
npm error Found: [email protected]
npm error node_modules/react
npm error   react@"^19.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer react@"17 - 18" from @frigade/[email protected]
npm error node_modules/@frigade/react
npm error   @frigade/react@"^2.6.7" from the root project

@swiecki
Copy link

swiecki commented Jan 11, 2025

Hi, this is the last package blocking our upgrade to nextjs 15 from 14.

Found: [email protected]
node_modules/react
  react@"19.0.0" from the root project

Could not resolve dependency:
peer react@"17 - 18" from @frigade/[email protected]
node_modules/@frigade/react
  @frigade/react@"^2.7.1" from the root project

Fix the upstream dependency conflict, or retry
this command with --force or --legacy-peer-deps
to accept an incorrect (and potentially broken) dependency resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants