Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0 Breaking Changes #4

Open
5 tasks
UncleClapton opened this issue Jan 14, 2021 · 0 comments
Open
5 tasks

v2.0 Breaking Changes #4

UncleClapton opened this issue Jan 14, 2021 · 0 comments
Assignees

Comments

@UncleClapton
Copy link
Member

UncleClapton commented Jan 14, 2021

⚠WORK IN PROGRESS⚠

This is a list of major changes to the style guide that we want to include in a v2 release. Any change that is deemed "breaking" or "time consuming" refactor should be placed here.

Each change will be listed as an abstract goal, and rules to be changed shall be listed underneath.

Changes

  • Prefer modern color syntax (rgb(0 0 0 / 1.0))
    • color-function-notation: 'modern'
    • color-no-hex: true
    • color-no-invalid-hex: null
    • color-hex-case: null
    • color-hex-length: null
  • Disallow SCSS global functions. Prefer explicit modules instead.
    • scss/no-global-function-names: true
  • Disallow duplicate SCSS variables.
    • scss/no-duplicate-dollar-variables: true
  • Make CSS Module support an optional plugin config.
    • property-no-unknown: (move ignoreProperties and ignoreSelectors)
    • declaration-block-no-duplicate-properties: (move ignoreProperties)
    • selector-pseudo-class-no-unknown: (move ignorePseudoClasses)
    • value-keyword-case: (move ignoreProperties)
    • at-rule-no-unknown & scss/at-rule-no-unknown: (move ignoreAtRules)
      • Rule will also be overridden by plugin/scss so steps will need to be made to ensure interop. (perhaps a separate file plugin/scss-modules)
  • Make SCSS an optional plugin config.
    • at-rule-no-unknown: true
      • Rule should be disabled by /plugin/scss
    • no-invalid-double-slash-comments: null in /plugin/scss
      • We should take this opportunity to allow single line comments in SCSS, which is valid for the syntax.
@UncleClapton UncleClapton self-assigned this Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant