Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D particle emitter improvements #1110

Open
1 of 10 tasks
jack-ii opened this issue Nov 28, 2023 · 4 comments
Open
1 of 10 tasks

3D particle emitter improvements #1110

jack-ii opened this issue Nov 28, 2023 · 4 comments
Labels
⚠ Issue with an extension An issue with an extension that is already on the extension store

Comments

@jack-ii
Copy link

jack-ii commented Nov 28, 2023

Is there an existing issue for this?

Enter the name of the extension

3D particle emitter

Describe the bug of the extension

  • The Hide/Show actions dont work. fix or remove
    Also the available object-effect and size actions have no result.

  • Swap the position of End & Start color/opacity in the properties so that it is more intuitive and consistent with the 2D emitter

  • Move the Z position from object properties window into properties side panel, like 3D objects
    Then 3D-Emitters are not overlapped by every 3D object in the scene-editor and it is also possible for instances to have a different z position without doing it with events

  • Add (0 = infinitely) to the Emission duration property and action

  • Particle emitters placed in the scene are always active for a moment after the scene starts
    (0.0001 Duration or 0 Flow doesn't help)
    Maybe an Enable checkbox and action would be possible. Or 0 is 0 and a checkbox/action for endless duration

  • I am unable to create a dark gray smoke because these colors become invisible, even without a light layer, 255 opacity, and dark particle image

  • Add 3D particle emitter to GD
    The extension code is big and will get bigger in the future with more premade effects and is already available in the New object list without the extension being installed.

Because both extensions are from the same dev, two things about CurvedMovement(speed-based)

  • Allow to move backwards without flipping the sprite/3D-object
    If I use a minus value in the acceleration action to drive a car/train backwards, it flips automatically so that the front side is always forward. Maybe a checkbox to not do this or an action to change the Rotation offset in the behavior.

  • Swap the position of Acceleration and Targeted speed fields in der Acceleration action, to be more intuitive and fit the eventsheet order
    01
    02

Steps to reproduce

.

GDevelop platform

Desktop

GDevelop version

5.3.181

Platform info

No response

Additional context

No response

@jack-ii jack-ii added the ⚠ Issue with an extension An issue with an extension that is already on the extension store label Nov 28, 2023
@D8H
Copy link
Contributor

D8H commented Nov 28, 2023

Thanks for the feedback.

3D particle emitter

Describe the bug of the extension

  • The Hide/Show actions dont work. fix or remove
    Also the available object-effect and size actions have no result.

Particles rendering is batched by the library I use so the default hide implementation doesn't work. I could try to override it but it may cause issues in the future and I doubt hiding particle is really useful.

  • Swap the position of End & Start color/opacity in the properties so that it is more intuitive and consistent with the 2D emitter

This is a limitation of the community extension system. It sorts alphabetically.

  • Move the Z position from object properties window into properties side panel, like 3D objects
    Then 3D-Emitters are not overlapped by every 3D object in the scene-editor and it is also possible for instances to have a different z position without doing it with events

Custom objects were made for 2D. It's a limitation of the community extension system.

  • Add (0 = infinitely) to the Emission duration property and action

I will at some point. The workaround is to put a big value. For instance, 123456 seconds = 35 hours.

  • Particle emitters placed in the scene are always active for a moment after the scene starts
    (0.0001 Duration or 0 Flow doesn't help)
    Maybe an Enable checkbox and action would be possible. Or 0 is 0 and a checkbox/action for endless duration

Interesting, I should try to fix this.

  • I am unable to create a dark gray smoke because these colors become invisible, even without a light layer, 255 opacity, and dark particle image

I'm not sure to understand. Is it because of the blending property is set on additive? I guess that additive and black is just adding 0.

  • Add 3D particle emitter to GD
    The extension code is big and will get bigger in the future with more premade effects and is already available in the New object list without the extension being installed.

The extension code size is not really how built-in extension are chosen but the code comes from a library so it already allows very advanced features and only 5% is actually used.

Because both extensions are from the same dev, two things about CurvedMovement(speed-based)

  • Allow to move backwards without flipping the sprite/3D-object
    If I use a minus value in the acceleration action to drive a car/train backwards, it flips automatically so that the front side is always forward. Maybe a checkbox to not do this or an action to change the Rotation offset in the behavior.

I though it was already the case. In the examples, the train can go backward like a train.

  • Swap the position of Acceleration and Targeted speed fields in der Acceleration action, to be more intuitive and fit the eventsheet order

I'm not sure if it would be more intuitive or not, but it probably not worth deprecating the action just to change the parameter order.

@jack-ii
Copy link
Author

jack-ii commented Nov 28, 2023

Thanks for the quick and good response.

I will at some point. The workaround is to put a big value.

I meant add the text "0 = infinitely" in the action description. 0 already causes endless running time.

Is it because of the blending property is set on additive?

I think that's it, thank you.

The extension code size is not really how built-in extension are chosen but the code comes from a library so it already allows very advanced features and only 5% is actually used.

It seems a bit random which features are built in and which are extensions. My feeling was that if they are more complex and are not needed very rarely, they should be built in. To avoid the limitation of the extension system as in this case.

I though it was already the case. In the examples, the train can go backward like a train.

In Train(isometry) yes, in Train(top-down) not. I don't really see what the difference is, but I'll try again.

probably not worth deprecating the action just to change the parameter order.

I'm not sure what that means, but it looks like it takes two minutes and has no disadvantages.

@D8H
Copy link
Contributor

D8H commented Nov 28, 2023

I'm not sure what that means, but it looks like it takes two minutes and has no disadvantages.

It would be quick to change it in the extension but it would be a new action and the old one would be hidden. When you edit an action and it doesn't select anything in the action list, it's because it was hidden (deprecated).

@D8H
Copy link
Contributor

D8H commented Nov 28, 2023

In Train(isometry) yes, in Train(top-down) not. I don't really see what the difference is, but I'll try again.

Indeed, the isometric train doesn't rotate, it changes its animation. I guess the rotation can be done manually according to the movement angle and the speed but a property would probably be better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Issue with an extension An issue with an extension that is already on the extension store
Projects
None yet
Development

No branches or pull requests

2 participants