From 349a4ae7727284a3f900ce70a979886b6a273cf1 Mon Sep 17 00:00:00 2001 From: Tristan Rhodes Date: Sun, 3 Dec 2023 14:25:15 -0700 Subject: [PATCH 1/3] [Flash object] Added get/set functions for half-time property - Changed an input parameter to type "effect" - Minor wording changes --- extensions/reviewed/Flash.json | 348 ++++++++++++++++++++++++++++++++- 1 file changed, 341 insertions(+), 7 deletions(-) diff --git a/extensions/reviewed/Flash.json b/extensions/reviewed/Flash.json index 861b95ea..f8f1bfda 100644 --- a/extensions/reviewed/Flash.json +++ b/extensions/reviewed/Flash.json @@ -1,6 +1,6 @@ { "author": "@4ian, Entropy, VegeTato", - "category": "", + "category": "Visual effect", "extensionNamespace": "", "fullName": "Flash object", "helpPath": "", @@ -8,7 +8,7 @@ "name": "Flash", "previewIconUrl": "https://resources.gdevelop-app.com/assets/Icons/flash-outline.svg", "shortDescription": "Make an object flash visibility (blink), color tint, object effect, or opacity (fade).", - "version": "1.1.1", + "version": "1.2.0", "description": [ "Make an object flash for a period of time so that it alternates between two different states.", "Includes the ability to flash visibility (blink), color tint, object effect, or opacity (fade).", @@ -20,6 +20,10 @@ "- Catch player attention on the interface (for instance a \"press start\" text)", "" ], + "origin": { + "identifier": "Flash", + "name": "gdevelop-extension-store" + }, "tags": [ "tween", "flash", @@ -240,7 +244,7 @@ { "description": "Effect name to toggle", "name": "EffectName", - "type": "string" + "type": "objectEffectName" } ], "objectGroups": [] @@ -909,6 +913,87 @@ } ], "objectGroups": [] + }, + { + "description": "the half period (time during which object is invisible) of the object.", + "fullName": "Half period (time during which object is invisible)", + "functionType": "ExpressionAndCondition", + "group": "Flash visibility (blink) configuration", + "name": "HalfPeriodTime", + "sentence": "the half period (time during which object is invisible)", + "events": [ + { + "type": "BuiltinCommonInstructions::Standard", + "conditions": [], + "actions": [ + { + "type": { + "value": "SetReturnNumber" + }, + "parameters": [ + "Object.Behavior::PropertyHalfPeriodTime()" + ] + } + ] + } + ], + "expressionType": { + "type": "expression" + }, + "parameters": [ + { + "description": "Object", + "name": "Object", + "type": "object" + }, + { + "description": "Behavior", + "name": "Behavior", + "supplementaryInformation": "Flash::Flash", + "type": "behavior" + } + ], + "objectGroups": [] + }, + { + "fullName": "", + "functionType": "ActionWithOperator", + "getterName": "HalfPeriodTime", + "name": "SetHalfPeriodTime", + "sentence": "", + "events": [ + { + "type": "BuiltinCommonInstructions::Standard", + "conditions": [], + "actions": [ + { + "type": { + "value": "Flash::Flash::SetPropertyHalfPeriodTime" + }, + "parameters": [ + "Object", + "Behavior", + "=", + "GetArgumentAsNumber(\"Value\")" + ] + } + ] + } + ], + "parameters": [ + { + "description": "Object", + "name": "Object", + "type": "object" + }, + { + "description": "Behavior", + "name": "Behavior", + "supplementaryInformation": "Flash::Flash", + "type": "behavior" + } + ], + "objectGroups": [] } ], "propertyDescriptors": [ @@ -1096,7 +1181,7 @@ }, { "description": "Make an object flash a color tint for a period of time.", - "fullName": "Flash color tint", + "fullName": "Flash a color tint", "functionType": "Action", "name": "Flash", "sentence": "Make _PARAM0_ flash the color tint _PARAM3_ for _PARAM2_ seconds", @@ -1401,6 +1486,89 @@ } ], "objectGroups": [] + }, + { + "description": "the half period (time between flashes) of the object.", + "fullName": "Half period (time between flashes)", + "functionType": "ExpressionAndCondition", + "group": "Flash color tint configuration", + "name": "HalfPeriodTime", + "sentence": "the half period (time between flashes)", + "events": [ + { + "type": "BuiltinCommonInstructions::Standard", + "conditions": [], + "actions": [ + { + "type": { + "value": "SetReturnNumber" + }, + "parameters": [ + "Object.Behavior::PropertyHalfPeriodTime()" + ] + } + ] + } + ], + "expressionType": { + "type": "expression" + }, + "parameters": [ + { + "description": "Object", + "name": "Object", + "supplementaryInformation": "Sprite", + "type": "object" + }, + { + "description": "Behavior", + "name": "Behavior", + "supplementaryInformation": "Flash::FlashColor", + "type": "behavior" + } + ], + "objectGroups": [] + }, + { + "fullName": "", + "functionType": "ActionWithOperator", + "getterName": "HalfPeriodTime", + "name": "SetHalfPeriodTime", + "sentence": "", + "events": [ + { + "type": "BuiltinCommonInstructions::Standard", + "conditions": [], + "actions": [ + { + "type": { + "value": "Flash::FlashColor::SetPropertyHalfPeriodTime" + }, + "parameters": [ + "Object", + "Behavior", + "=", + "GetArgumentAsNumber(\"Value\")" + ] + } + ] + } + ], + "parameters": [ + { + "description": "Object", + "name": "Object", + "supplementaryInformation": "Sprite", + "type": "object" + }, + { + "description": "Behavior", + "name": "Behavior", + "supplementaryInformation": "Flash::FlashColor", + "type": "behavior" + } + ], + "objectGroups": [] } ], "propertyDescriptors": [ @@ -1643,7 +1811,7 @@ }, { "description": "Make an object flash opacity smoothly (fade) in a repeating loop.", - "fullName": "Flash opacity (fade)", + "fullName": "Flash the opacity (fade)", "functionType": "Action", "name": "Flash", "sentence": "Make _PARAM0_ flash opacity smoothly to _PARAM4_ in a loop for _PARAM3_ seconds", @@ -1961,6 +2129,89 @@ } ], "objectGroups": [] + }, + { + "description": "the half period (time between flashes), in seconds of the object.", + "fullName": "Half period (time between flashes), in seconds", + "functionType": "ExpressionAndCondition", + "group": "Flash opacity smothly (fade) configuration", + "name": "HalfPeriodTime", + "sentence": "the half period (time between flashes), in seconds", + "events": [ + { + "type": "BuiltinCommonInstructions::Standard", + "conditions": [], + "actions": [ + { + "type": { + "value": "SetReturnNumber" + }, + "parameters": [ + "Object.Behavior::PropertyHalfPeriodTime()" + ] + } + ] + } + ], + "expressionType": { + "type": "expression" + }, + "parameters": [ + { + "description": "Object", + "name": "Object", + "supplementaryInformation": "Sprite", + "type": "object" + }, + { + "description": "Behavior", + "name": "Behavior", + "supplementaryInformation": "Flash::FlashOpacity", + "type": "behavior" + } + ], + "objectGroups": [] + }, + { + "fullName": "", + "functionType": "ActionWithOperator", + "getterName": "HalfPeriodTime", + "name": "SetHalfPeriodTime", + "sentence": "", + "events": [ + { + "type": "BuiltinCommonInstructions::Standard", + "conditions": [], + "actions": [ + { + "type": { + "value": "Flash::FlashOpacity::SetPropertyHalfPeriodTime" + }, + "parameters": [ + "Object", + "Behavior", + "=", + "GetArgumentAsNumber(\"Value\")" + ] + } + ] + } + ], + "parameters": [ + { + "description": "Object", + "name": "Object", + "supplementaryInformation": "Sprite", + "type": "object" + }, + { + "description": "Behavior", + "name": "Behavior", + "supplementaryInformation": "Flash::FlashOpacity", + "type": "behavior" + } + ], + "objectGroups": [] } ], "propertyDescriptors": [ @@ -2183,7 +2434,7 @@ }, { "description": "Make an object flash an effect for a period of time.", - "fullName": "Flash effect", + "fullName": "Flash an effect", "functionType": "Action", "name": "Flash", "sentence": "Make _PARAM0_ flash the effect _PARAM3_ for _PARAM2_ seconds", @@ -2406,7 +2657,7 @@ { "description": "Name of effect", "name": "EffectName", - "type": "string" + "type": "objectEffectName" } ], "objectGroups": [] @@ -2635,6 +2886,89 @@ } ], "objectGroups": [] + }, + { + "description": "the half period (time between flashes), in seconds of the object.", + "fullName": "Half period (time between flashes), in seconds", + "functionType": "ExpressionAndCondition", + "group": "Flash effect configuration", + "name": "HalfPeriodTime", + "sentence": "the half period (time between flashes), in seconds", + "events": [ + { + "type": "BuiltinCommonInstructions::Standard", + "conditions": [], + "actions": [ + { + "type": { + "value": "SetReturnNumber" + }, + "parameters": [ + "Object.Behavior::PropertyHalfPeriodTime()" + ] + } + ] + } + ], + "expressionType": { + "type": "expression" + }, + "parameters": [ + { + "description": "Object", + "name": "Object", + "supplementaryInformation": "Sprite", + "type": "object" + }, + { + "description": "Behavior", + "name": "Behavior", + "supplementaryInformation": "Flash::FlashEffect", + "type": "behavior" + } + ], + "objectGroups": [] + }, + { + "fullName": "", + "functionType": "ActionWithOperator", + "getterName": "HalfPeriodTime", + "name": "SetHalfPeriodTime", + "sentence": "", + "events": [ + { + "type": "BuiltinCommonInstructions::Standard", + "conditions": [], + "actions": [ + { + "type": { + "value": "Flash::FlashEffect::SetPropertyHalfPeriodTime" + }, + "parameters": [ + "Object", + "Behavior", + "=", + "GetArgumentAsNumber(\"Value\")" + ] + } + ] + } + ], + "parameters": [ + { + "description": "Object", + "name": "Object", + "supplementaryInformation": "Sprite", + "type": "object" + }, + { + "description": "Behavior", + "name": "Behavior", + "supplementaryInformation": "Flash::FlashEffect", + "type": "behavior" + } + ], + "objectGroups": [] } ], "propertyDescriptors": [ From cf13946c0ed5b321d851f2bcf4926985c19d4840 Mon Sep 17 00:00:00 2001 From: Tristan Rhodes Date: Sun, 3 Dec 2023 16:19:53 -0700 Subject: [PATCH 2/3] Update extensions/reviewed/Flash.json Co-authored-by: D8H --- extensions/reviewed/Flash.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/extensions/reviewed/Flash.json b/extensions/reviewed/Flash.json index f8f1bfda..2422c0b3 100644 --- a/extensions/reviewed/Flash.json +++ b/extensions/reviewed/Flash.json @@ -916,7 +916,7 @@ }, { "description": "the half period (time during which object is invisible) of the object.", - "fullName": "Half period (time during which object is invisible)", + "fullName": "Half period", "functionType": "ExpressionAndCondition", "group": "Flash visibility (blink) configuration", "name": "HalfPeriodTime", From 2fcf9d5756fb06bcf7b9c8ff0ca2fc031c0ff484 Mon Sep 17 00:00:00 2001 From: Tristan Rhodes Date: Sun, 3 Dec 2023 19:49:43 -0700 Subject: [PATCH 3/3] Updated wording How does this look, @D8H? --- extensions/reviewed/Flash.json | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/extensions/reviewed/Flash.json b/extensions/reviewed/Flash.json index 2422c0b3..22c174c7 100644 --- a/extensions/reviewed/Flash.json +++ b/extensions/reviewed/Flash.json @@ -915,12 +915,12 @@ "objectGroups": [] }, { - "description": "the half period (time during which object is invisible) of the object.", + "description": "the half period of the object (time the object is invisible).", "fullName": "Half period", "functionType": "ExpressionAndCondition", "group": "Flash visibility (blink) configuration", "name": "HalfPeriodTime", - "sentence": "the half period (time during which object is invisible)", + "sentence": "the half period (time the object is invisible)", "events": [ { "type": "BuiltinCommonInstructions::Standard", @@ -1001,8 +1001,8 @@ "value": "0.1", "type": "Number", "unit": "Second", - "label": "Half period (time during which object is invisible)", - "description": "", + "label": "Half period ", + "description": "Time that the object is invisible", "group": "", "extraInformation": [], "hidden": false, @@ -1489,7 +1489,7 @@ }, { "description": "the half period (time between flashes) of the object.", - "fullName": "Half period (time between flashes)", + "fullName": "Half period", "functionType": "ExpressionAndCondition", "group": "Flash color tint configuration", "name": "HalfPeriodTime", @@ -1576,8 +1576,8 @@ "value": "0.1", "type": "Number", "unit": "Second", - "label": "Half period (time between flashes)", - "description": "", + "label": "Half period", + "description": "Time between flashes", "group": "", "extraInformation": [], "hidden": false, @@ -2131,12 +2131,12 @@ "objectGroups": [] }, { - "description": "the half period (time between flashes), in seconds of the object.", - "fullName": "Half period (time between flashes), in seconds", + "description": "the half period (time between flashes) of the object.", + "fullName": "Half period", "functionType": "ExpressionAndCondition", "group": "Flash opacity smothly (fade) configuration", "name": "HalfPeriodTime", - "sentence": "the half period (time between flashes), in seconds", + "sentence": "the half period (time between flashes)", "events": [ { "type": "BuiltinCommonInstructions::Standard", @@ -2231,8 +2231,8 @@ "value": "0.1", "type": "Number", "unit": "Second", - "label": "Half period (time between flashes), in seconds", - "description": "", + "label": "Half period", + "description": "Time between flashes", "group": "", "extraInformation": [], "hidden": false, @@ -2888,12 +2888,12 @@ "objectGroups": [] }, { - "description": "the half period (time between flashes), in seconds of the object.", - "fullName": "Half period (time between flashes), in seconds", + "description": "the half period (time between flashes) of the object.", + "fullName": "Half period", "functionType": "ExpressionAndCondition", "group": "Flash effect configuration", "name": "HalfPeriodTime", - "sentence": "the half period (time between flashes), in seconds", + "sentence": "the half period (time between flashes)", "events": [ { "type": "BuiltinCommonInstructions::Standard", @@ -2976,8 +2976,8 @@ "value": "0.1", "type": "Number", "unit": "Second", - "label": "Half period (time between flashes), in seconds", - "description": "", + "label": "Half period", + "description": "Time between flashes", "group": "", "extraInformation": [], "hidden": false,