Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for scripts like train_hypergrid with replay_buffer > 0 #167

Open
saleml opened this issue Feb 27, 2024 · 2 comments
Open

Add tests for scripts like train_hypergrid with replay_buffer > 0 #167

saleml opened this issue Feb 27, 2024 · 2 comments
Assignees
Labels
bug Something isn't working high priority Let's do these first! question Further information is requested
Milestone

Comments

@saleml
Copy link
Collaborator

saleml commented Feb 27, 2024

A recent PR introduced a bug where train_hypergrid doesn't converge if replay_buffer is set to 100.

This should be caught with the tests !

@josephdviviano josephdviviano added this to the V2 milestone Apr 16, 2024
@josephdviviano josephdviviano self-assigned this Jun 12, 2024
@josephdviviano josephdviviano added the high priority Let's do these first! label Jun 12, 2024
@josephdviviano josephdviviano added bug Something isn't working question Further information is requested labels Jan 13, 2025
@josephdviviano
Copy link
Collaborator

@hyeok9855 could you check that the test coverage currently handles cases with replay buffers so our tests catch any problems with the planned changes to those objects?

@hyeok9855
Copy link
Collaborator

Yes, of course. I also wanted to check the buffer side. I planned to add an example that uses the replay buffer for off-policy training. I will also check the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high priority Let's do these first! question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants