Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for replay buffers are not sufficient #198

Open
josephdviviano opened this issue Oct 11, 2024 · 0 comments
Open

Tests for replay buffers are not sufficient #198

josephdviviano opened this issue Oct 11, 2024 · 0 comments
Assignees
@josephdviviano
Labels
bug Something isn't working help wanted Extra attention is needed high priority Let's do these first!

Comments

@josephdviviano
Copy link
Collaborator

A recent PR unconvered a fairly serious bug in the implementation of one replay buffer. I think we should have a close look at the associated tests, and write more to avoid this in the future.
@josephdviviano josephdviviano added bug Something isn't working help wanted Extra attention is needed labels Oct 11, 2024
@josephdviviano josephdviviano self-assigned this Oct 11, 2024
@josephdviviano josephdviviano mentioned this issue Oct 11, 2024
Merged
@josephdviviano josephdviviano added the high priority Let's do these first! label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@josephdviviano josephdviviano

Labels
bug Something isn't working help wanted Extra attention is needed high priority Let's do these first!
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@josephdviviano