Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration tests with database connection #814

Open
matthiasschaub opened this issue Aug 26, 2024 · 2 comments
Open

Add integration tests with database connection #814

matthiasschaub opened this issue Aug 26, 2024 · 2 comments
Assignees
Labels
tests Issues with tests

Comments

@matthiasschaub
Copy link
Collaborator

matthiasschaub commented Aug 26, 2024

Currently, tests are mocking every database connection or are skipped (pytest.mark.skip in test_geodatabase.py).
In order to cleanup database-access-related code (especially avoid having 2 different persistence libraries),
the geo-database tests have to be reactivated first.

Tasks:

  • reactivate existing geo-database tests
  • consider using the PostGIS module of test containers
  • find an appropriate subset for populating the test database
  • try running the Jenkins build outside docker in order to avoid problems with test containers

Blocks #746

@mmerdes
Copy link
Collaborator

mmerdes commented Aug 27, 2024

@joker234
It would be great if we could try to run the Jenkins build outside Docker some time as this would enable using the test containers library.

@joker234
Copy link
Member

joker234 commented Aug 27, 2024

@joker234 It would be great if we could try to run the Jenkins build outside Docker some time as this would enable using the test containers library.

see PR #817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues with tests
Projects
None yet
Development

No branches or pull requests

3 participants