Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataModule and Data Import are combined #69

Open
mikewoodward94 opened this issue Aug 13, 2024 · 0 comments · May be fixed by #70
Open

DataModule and Data Import are combined #69

mikewoodward94 opened this issue Aug 13, 2024 · 0 comments · May be fixed by #70
Assignees

Comments

@mikewoodward94
Copy link
Contributor

In the current implementation the data import happens at the time the PyTorch Lightning DataModule is initialised.

This is a bit messy, and also makes unit testing harder.

Splitting out the data import and the datamodule will make the code clearer, allow for easier adaptability, and allow for unit testing or even data quality checks before training begins.

@mikewoodward94 mikewoodward94 self-assigned this Aug 13, 2024
@mikewoodward94 mikewoodward94 linked a pull request Aug 13, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant