Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ichorium block does not function as Node Linker stabilizer #18861

Open
3 tasks done
niceping opened this issue Jan 24, 2025 · 3 comments
Open
3 tasks done

Ichorium block does not function as Node Linker stabilizer #18861

niceping opened this issue Jan 24, 2025 · 3 comments
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed

Comments

@niceping
Copy link

niceping commented Jan 24, 2025

Your GTNH Discord Username

nice ping

Your Pack Version

2.7.2

Your Server

SP

Java Version

Java 8

Type of Server

Single Player

Your Expectation

Thaumonomicon entry for Node Linker from Thaumic Bases explicitly mentions that a block of some metal can be used to stabilize the process of node linking. Investigation of code for Node Linker reveals said material to be Ichorium, and thus it would be expected to be able to use this block to stop instability events from occurring.

Image

The Reality

In reality, the block of Ichorium does absolutely nothing to prevent instability events. In addition, I checked ShadowOfX & Threefold's google spreadsheet, and it also mentions Ichorium block not functioning as stabilizer.

Image

Image

Your Proposal

Make Ichorium block actually work, or make some other magic metal block replace it and change the Thaumonomicon entry for Node Linker appropriately.

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@niceping niceping added Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed labels Jan 24, 2025
@C-Remilian
Copy link
Contributor

The function right after your shown snippet, instabilityCheck(), contains instability code. In it it is shown that only the 2 most severe events (node explosion and node harm) are stopped from occurring if a stabilizing block is present. Your screenshot only shows flux event, which is not excluded.
Looks like intended behavior. If the last contributor to that function intended to exclude all events then the block check would be at the beginning of the instability function and not confined to only 2 events.

@niceping
Copy link
Author

Very curious. It is unfortunate that it other instability events seem to be intended to occur even with ichorium block, since Thaumonomicon entry implied all instability events would be stopped. I'll do more testing in creative later today, as well as re-read the entry to make sure that I didn't misunderstood the wording.

@niceping
Copy link
Author

Alright, after some brief testing, it doesn't seem like node linkers actually explode, with or without stabilizer. This will require more testing, since sample size is pretty small, but you'd think that out of three node linkers transfering aspects for 15 minutes straight, one of them would explode at some point, given amount of wisps and flux they spawned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Minor Status: Triage Issue awaiting triage. Remove once this issue is processed
Projects
None yet
Development

No branches or pull requests

2 participants