Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add folder icon support for OG Xbox games #436

Closed
Masamune3210 opened this issue Jan 21, 2025 · 4 comments
Closed

Add folder icon support for OG Xbox games #436

Masamune3210 opened this issue Jan 21, 2025 · 4 comments
Assignees
Milestone

Comments

@Masamune3210
Copy link

The game partition of a Xbox disc image (which the community seems to be obsessed with calling XISO, confusing numerous people daily) is regularly extracted to either be used in emulation or on actual hardware. Folder structure is the same as on disc, with the main executable (typically named default.xbe) being found directly inside the folder. Could support be added for showing the icon and property sheet on the folder should it be found?

@GerbilSoft
Copy link
Owner

This would be similar to what's done for Wii U packages (and extracted Wii U titles), so I'll look into it.

@GerbilSoft GerbilSoft self-assigned this Jan 21, 2025
@GerbilSoft GerbilSoft added this to the 2.5 milestone Jan 21, 2025
GerbilSoft added a commit that referenced this issue Jan 25, 2025
Changed "Extracted XDVDFS" to "XDVDFS Partition".

RomDataFactory: Add XboxDisc to the directory check

See #436: Add folder icon support for OG Xbox games
Suggested by @Masamume3210.
@GerbilSoft
Copy link
Owner

GerbilSoft commented Jan 25, 2025

Turned out to be fairly straightforward to add.

Some issues encountered:

  • There was already a type called "Extracted", which referred to a standalone XDVDFS partition. This is now just "XDVDFS".
  • Adding "Extracted" bumped up the enum values, which broke XGD detection because that relied on the enum values matching the XGD version. XGD detection now uses the enum values.
  • XDVDFS, like most Windows file systems, is case-insensitive. Linux file systems are usually case-sensitive. The disc image I tested, "Kinect Rush: A Disney Pixar Adventure", has the boot filename "Default.xex", which breaks on Linux if searching for "default.xex". I added a few permutations that should fix this in most cases, but if there's any others, I'll need to add them later.

Will merge this to master once I verify that the Windows build isn't broken. Please let me know if there's any disc images that aren't detected properly due to case-sensitivity issues (or other issues).

@GerbilSoft
Copy link
Owner

Merged to master. Feel free to file a new issue if you encounter any issues as mentioned above.

@Masamune3210
Copy link
Author

Sweet! I'll try to test it out before release if I have a chance. Thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants