Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong selection used to apply bold/italic #27

Open
magiksd opened this issue Nov 14, 2018 · 6 comments
Open

Wrong selection used to apply bold/italic #27

magiksd opened this issue Nov 14, 2018 · 6 comments

Comments

@magiksd
Copy link

magiksd commented Nov 14, 2018

Hello, I'm currently implementing your awesome tool in my CMS, but I encountered a weird bug when simply applying a bold or italic on text.

See it by yourself on the demo :

  1. Start a new paragraph
  2. Write "aaaaa bbbbb"
  3. Select "bbbbb"
  4. Set it bold or italic
  5. Bug happen

Another way to see it :

  1. Start a new paragraph
  2. Write "aaaaa bbbbb"
  3. Set bold to "aaaaa"
  4. Set italic to "bbbbb"
  5. Select all text
  6. Set it bold
  7. Bug happen again

In both cases, selection seems to change before applying.

@anthonyjb
Copy link
Member

Hey @magiksd could you let me know what browser and version of CT your using please. I'm not able to repeat the bug in Chrome on the demo page per your instructions.

@magiksd
Copy link
Author

magiksd commented Nov 14, 2018

Thank you for your quick answer. Indeed, I just tried in Chrome and the bug is not present. I encountered it in Firefox 63.0 on Ubuntu and Windows.

@anthonyjb
Copy link
Member

OK I can repeat this in firefox - it's an odd one - once you click away and re-enter the paragraph the bug is not longer present. I'll flag this as a bug and take a look ASAP - the issue will be in ContentSelect I'm sure so will fix there and bring CT up to date.

@magiksd
Copy link
Author

magiksd commented Nov 14, 2018

Thank you :)

@magiksd
Copy link
Author

magiksd commented Nov 15, 2018

Hello, I just noticed that the bug only occurs when double clicking the part to select, not when selecting carefully with the mouse, maybe this will help.

@anthonyjb
Copy link
Member

@magiksd thanks for the extra info - much appreciated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants