Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IsPureDirectResource hack #3614

Open
3 tasks done
jasonvigil opened this issue Feb 5, 2025 · 0 comments
Open
3 tasks done

Remove IsPureDirectResource hack #3614

jasonvigil opened this issue Feb 5, 2025 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@jasonvigil
Copy link
Collaborator

Checklist

  • I did not find a related open enhancement request.
  • I understand that enhancement requests filed in the GitHub repository are by default low priority.
  • If this request is time-sensitive, I have submitted a corresponding issue with GCP support.

Describe the feature or resource

Similar to #3443, we have an opportunity to remove the need for the IsPureDirectResource hack. It's probably possible to compute these values, instead of hardcoding them.

func IsPureDirectResource(gk schema.GroupKind) bool {
pureDirectResources := []string{
"ApigeeEnvgroup",
"BigQueryConnectionConnection",
"BigQueryDataTransferConfig",
"CloudBuildWorkerPool",
"DataformRepository",
"FirestoreDatabase",
"NetworkConnectivityServiceConnectionPolicy",
"PrivilegedAccessManagerEntitlement",
"RedisCluster",
"BigQueryAnalyticsHubDataExchange",
"BigQueryAnalyticsHubListing",
"WorkstationCluster",
"WorkstationConfig",
"Workstation",
"KMSAutokeyConfig",
"KMSKeyHandle",
"SecureSourceManagerInstance",
"SecureSourceManagerRepository",
}
return slices.Contains(pureDirectResources, gk.Kind)
}

We should also update the direct controller guide to remove instructions related to this manual update:

* For resource that is purely direct controller based, add the resource name to `pureDirectResources` in `IsPureDirectResource` function in [sets.go](https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/pkg/test/resourcefixture/sets.go).

Additional information

No response

Importance

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants