Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: ConfigSync installation applies ClusterRegistry CRD, is that necessary? #724

Open
johnbelamaric opened this issue Jul 6, 2023 · 3 comments

Comments

@johnbelamaric
Copy link
Member

This causes problems because it registers the resource "clusters", which is shared, for example, with the Cluster API project. This can cause kubectl, etc. to be confused.

We may want to look over https://github.com/GoogleContainerTools/kpt-config-sync/tree/main/manifests and make sure we only apply the ones to the cluster that are actually needed at runtime by CS.

See also: nephio-project/nephio#327

@johnbelamaric
Copy link
Member Author

To be clear - we are installing CS via config-management-operator.

@johnbelamaric
Copy link
Member Author

@karlkfi

@karlkfi
Copy link
Contributor

karlkfi commented Jan 24, 2025

Is this still a problem, @johnbelamaric?

I don't see any ClusterRegistry resource manifests or CRDs in the repo.

I'm pretty sure ConfigSync excludes all objects in the /clusterregistry/ directory at the root of the repository. So if your Cluster object is there, to configure cluster labels, it shouldn't be applied.

For any other objects in your source repo you dont want applied you can add the config.kubernetes.io/local-config: "true" annotation.

@karlkfi karlkfi changed the title ConfigSync installation applies ClusterRegistry CRD, is that necessary? Bug: ConfigSync installation applies ClusterRegistry CRD, is that necessary? Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants