-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial view of this planter is wrong #1332
Comments
@dadiorchen this one and #1325 are the part of the same problem. It happens in web map core library, because of the page width (we need it for calculating zoomlevel). It is in any cases (embed or not) width: window.innerWidth (check Map.js from core), as I understand it should be half of the window.innerWidth, when you see the left part. I am not sure about the solution, may be send an extra parameter to the web map cor? So for fix his we need to update core and client at the same time, may be you have more elegant solution? |
And i think the reproducibility of the error only depends on the width of your browser, which is why @jeremydthomas doesn't reproduce it in #1325. |
I agree with the width part, Ive been trying to figure this one out and sometimes it works and sometimes it doesnt. Also when there is a bounds, sometimes it works and sometimes it doesnt. |
@SuokN ohhhhhh! Wonderful catching!!! this does make sense! Let's go this direction, @SuokN would you go for it? Greenstand/treetracker-web-map-core#153 |
@dadiorchen Ok, I will do it |
@SuokN are you in the community? What's your name over there? |
@SuokN do you think this is the same problem? https://beta-map.treetracker.org/wallets/f3d90452-12c6-4c23-8d2f-6cfa2ddc203b |
I think so, in new version this initial view is ok. |
@SuokN did you raise a PR for this? The new version? |
I mean for the web map client |
yes, it is in the last version of web-map-core |
@SuokN could you raise a PR to install the new one in the web map client? |
ok |
Initial view of this planter is wrong #1332
🎉 This issue has been resolved in version 2.0.0-beta.229 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description
https://beta-map.treetracker.org/planters/6822
Can not see any icons on the initial view
To reproduce
Some hints:
The text was updated successfully, but these errors were encountered: