Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial view of this planter is wrong #1332

Closed
dadiorchen opened this issue Dec 26, 2022 · 14 comments · Fixed by #1385
Closed

Initial view of this planter is wrong #1332

dadiorchen opened this issue Dec 26, 2022 · 14 comments · Fixed by #1385
Labels
bug Something isn't working challenge hard, tricky, problem released on @beta web-map-core

Comments

@dadiorchen
Copy link
Collaborator

Description

https://beta-map.treetracker.org/planters/6822

Can not see any icons on the initial view

To reproduce


Some hints:

@dadiorchen dadiorchen added bug Something isn't working challenge hard, tricky, problem web-map-core labels Dec 26, 2022
@SuokN
Copy link
Contributor

SuokN commented Jan 11, 2023

@dadiorchen this one and #1325 are the part of the same problem. It happens in web map core library, because of the page width (we need it for calculating zoomlevel). It is in any cases (embed or not) width: window.innerWidth (check Map.js from core), as I understand it should be half of the window.innerWidth, when you see the left part. I am not sure about the solution, may be send an extra parameter to the web map cor? So for fix his we need to update core and client at the same time, may be you have more elegant solution?

@SuokN
Copy link
Contributor

SuokN commented Jan 11, 2023

And i think the reproducibility of the error only depends on the width of your browser, which is why @jeremydthomas doesn't reproduce it in #1325.

@jeremydthomas
Copy link
Member

I agree with the width part, Ive been trying to figure this one out and sometimes it works and sometimes it doesnt. Also when there is a bounds, sometimes it works and sometimes it doesnt.

@dadiorchen
Copy link
Collaborator Author

@SuokN ohhhhhh! Wonderful catching!!! this does make sense! Let's go this direction, @SuokN would you go for it? Greenstand/treetracker-web-map-core#153

@SuokN
Copy link
Contributor

SuokN commented Jan 12, 2023

@dadiorchen Ok, I will do it

@dadiorchen
Copy link
Collaborator Author

@SuokN are you in the community? What's your name over there?

@dadiorchen
Copy link
Collaborator Author

@SuokN do you think this is the same problem? https://beta-map.treetracker.org/wallets/f3d90452-12c6-4c23-8d2f-6cfa2ddc203b

@SuokN
Copy link
Contributor

SuokN commented Feb 5, 2023

I think so, in new version this initial view is ok.
I am in community Natasha Kazovskaya

@dadiorchen
Copy link
Collaborator Author

@SuokN did you raise a PR for this? The new version?

@dadiorchen
Copy link
Collaborator Author

I mean for the web map client

@SuokN
Copy link
Contributor

SuokN commented Feb 6, 2023

yes, it is in the last version of web-map-core

@dadiorchen
Copy link
Collaborator Author

dadiorchen commented Feb 7, 2023

@SuokN could you raise a PR to install the new one in the web map client?

@SuokN
Copy link
Contributor

SuokN commented Feb 7, 2023

ok

SuokN added a commit to SuokN/treetracker-web-map-client that referenced this issue Feb 7, 2023
dadiorchen added a commit that referenced this issue Feb 7, 2023
 Initial view of this planter is wrong #1332
@github-actions
Copy link

github-actions bot commented Feb 7, 2023

🎉 This issue has been resolved in version 2.0.0-beta.229 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working challenge hard, tricky, problem released on @beta web-map-core
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants