Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the capture list on /trees/{id} page #1587

Closed
dadiorchen opened this issue May 20, 2023 · 19 comments
Closed

Add the capture list on /trees/{id} page #1587

dadiorchen opened this issue May 20, 2023 · 19 comments

Comments

@dadiorchen
Copy link
Collaborator

Please help us add the capture list of the current tree on this page:

image

UX:

  • Put it under the tree picture and above the planter card
  • Reuse the component on the /top page for the image list, like the image below:
  • Change the text to: Captures match to this tree
  • By clicking the capture, jump to the capture page, which is: /v2/captures/{capture_id}
image

some hints:

@manishhansal
Copy link

@dadiorchen Could you please assign this to me? I would like to work on this feature.

@dadiorchen
Copy link
Collaborator Author

@manishhansal thank you, please, and note this issue is working on v2, please read the guide first

@manishhansal
Copy link

@manishhansal thank you, please, and note this issue is working on v2, please read the guide first

Okay

@dadiorchen
Copy link
Collaborator Author

This issue is open for everyone

@khalatevarun
Copy link
Contributor

Hey @dadiorchen would like to take this up

@dadiorchen
Copy link
Collaborator Author

@khalatevarun this one is important, thank you!

@khalatevarun
Copy link
Contributor

Hey @dadiorchen , i am v2 branch but not able to load data for any tree page.
I am able to open the captures/[capturid] page but on clicking on the "tree matched" it is redirection to tree page with 404 not found error

@dadiorchen
Copy link
Collaborator Author

@khalatevarun we need to change the logic for the tree page, previously, we use /trees/{id} to fetch tree data, in v2 we should use /v2/trees/{id}, basically, for the v2, we need always to request the query API v2, which means: dev-k8s.treetracker.org/query/v2/...

@dadiorchen
Copy link
Collaborator Author

Let me know if you still can not fix the problem

@khalatevarun
Copy link
Contributor

still getting 404 here :(

@dadiorchen
Copy link
Collaborator Author

@khalatevarun push your code maybe I can take a look

@dadiorchen
Copy link
Collaborator Author

@khalatevarun did you solve the problem? If not, can you push your code to your branch and let me take a look?

@khalatevarun
Copy link
Contributor

@dadiorchen i could not even start solving, since I am not able to open a tree page
I am v2 branch
I copy pasted env production into env development

Thats all I did

@dadiorchen
Copy link
Collaborator Author

@aayushgauba it might be also good to let you know about this discussion.

@khalatevarun I think the .env.production is problematic for v2, in the v2 branch the .env.development is the correct one for dev/test, there are some v2-specific settings:

NEXT_PUBLIC_API=https://dev-k8s.treetracker.org/query/v2
NEXT_PUBLIC_API_V2=https://dev-k8s.treetracker.org/
NEXT_PUBLIC_TILE_SERVER_URL=https://{s}.treetracker.org/tiles/
NEXT_PUBLIC_TILE_SERVER_SUBDOMAINS=dev-k8s
NEXT_PUBLIC_TILE_SERVER_WEBMAP_API=https://dev-k8s.treetracker.org/webmap/
NEXT_PUBLIC_IMAGE_API=https://dev-k8s.treetracker.org/images
NEXT_PUBLIC_API_NEW=http://127.0.0.1:4010/mock
NEXT_PUBLIC_BASE=
NEXT_PUBLIC_CONFIG_API=
NEXT_PUBLIC_COUNTRY_LEADER_BOARD_DISABLED=false
NEXT_PUBLIC_SERVER_CONFIG_DISABLED=true

There is a reason for the necessity of NEXT_PUBLIC_API_V2 but I forgot the details.

@dadiorchen
Copy link
Collaborator Author

basically, for v2 we use /query/v2 as the server api

@dadiorchen
Copy link
Collaborator Author

@aayushgauba what's the status of this issue?

@aayushgauba
Copy link

@dadiorchen working on it

@DylanJG01 DylanJG01 mentioned this issue Oct 23, 2023
Merged
5 tasks
@DylanJG01
Copy link
Member

@dadiorchen #1730 resolves this issue.

@dadiorchen
Copy link
Collaborator Author

@DylanJG01 I guess your comment doesn't follow the rule of github, so the issue didn't get closed automatically, like this: fixed: #xxx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🌱 Backlog
Development

No branches or pull requests

5 participants