Skip to content
This repository has been archived by the owner on Jun 22, 2020. It is now read-only.

Hard-Code error message in errors view #23

Open
NeverBehave opened this issue Mar 6, 2017 · 3 comments
Open

Hard-Code error message in errors view #23

NeverBehave opened this issue Mar 6, 2017 · 3 comments
Assignees

Comments

@NeverBehave
Copy link
Member

NeverBehave commented Mar 6, 2017

@wsjnohyeah Please don't hard code the error message in the error pages.
You can use {{ trans('messages.welcome') }} or @lang('messages.welcome') function if you need to insert a fixed message in the view.

You can check out the documentation here if you need some example, or you can check out the history version of 404.blade.php.

I have written some of the error messages so please follow the instruction XD, we need a Chinese version at the I18n Day.

NEXT TIME PLEASE READ AND FOLLOW THE EXISTING CODES:
IT IS ALSO AN IMPORTANT SKILL TO READ OTHERS CODES
RATHER THAN CLEAR THEM OUT AND APPLY YOUR IDEA DIRECTLY
THESE CODES ARE WRITTEN FOR REASONS
On the other hand, custom error looks good.

@wsjnohyeah
Copy link
Contributor

Error messages are passed in when abort() is called.
For default messages, maybe Lang is a better idea. But indeed there are lot of grammar mistakes

@yhylord
Copy link
Collaborator

yhylord commented Mar 6, 2017 via email

@NeverBehave
Copy link
Member Author

@wsjnohyeah Okey, XD I really appreciate if you can help fix these parts.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants