Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharpness addon: make "Effect strength" live #92

Open
humdingerb opened this issue Mar 27, 2022 · 3 comments · May be fixed by #658
Open

Sharpness addon: make "Effect strength" live #92

humdingerb opened this issue Mar 27, 2022 · 3 comments · May be fixed by #658
Labels
add-ons issues related to add-ons enhancement

Comments

@humdingerb
Copy link
Member

While the "Sharpness" slider takes effect while you move the slider's knob, the "Effect strength" slider only takes effect after letting go of the knob. All settings should be live, if possible.

@dsizzle
Copy link
Collaborator

dsizzle commented May 2, 2022

This might not be possible given the way the Sharpness add-on works. It looks like there's a blur map that gets generated based on the effect size, and it takes noticeable time. It can't update that map fast enough to give a good 'live' experience with this current implementation.

@humdingerb
Copy link
Member Author

OK. Shall we keep the issue open in case some dev gets inundated by a brain wave?

I can't dimmly remember that stippi described how he solved similar issues in WonderBrush 3. Something like threads being started and replaced by a new thread if the input data changes? The demo was quite cool, with some computational expensive effect (or layer blendings). He moved an object over the canvas and the effects got applied when there was CPU time. Very smooth...

Anyway, probably bigger fish to fry first...

@dsizzle
Copy link
Collaborator

dsizzle commented May 2, 2022

Yes, let's leave it open. There could be an answer in Wonderbrush, or maybe right here in ArtPaint. The Blur addon works live so maybe it does something smarter.

@dsizzle dsizzle added the add-ons issues related to add-ons label Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add-ons issues related to add-ons enhancement
Development

Successfully merging a pull request may close this issue.

2 participants