Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flappybalt: bounce panels resetting thier sprites to default on clearSave #366

Open
sol-vin opened this issue Nov 12, 2024 · 1 comment · May be fixed by #372
Open

Flappybalt: bounce panels resetting thier sprites to default on clearSave #366

sol-vin opened this issue Nov 12, 2024 · 1 comment · May be fixed by #372
Labels
Bug
Milestone
next patch

Comments

@sol-vin
Copy link

sol-vin commented Nov 12, 2024

Happens here: https://github.com/HaxeFlixel/flixel-demos/blob/dev/Arcade/Flappybalt/source/PlayState.hx#L153

Pressing Ctrl/Shift/Alt + E causes the panels to reset to their default sprite, probably because of FlxG.resetState.

2024-11-12.14-15-14.mp4
@Geokureli Geokureli added the Bug label Nov 13, 2024
@Geokureli Geokureli added this to the next patch milestone Nov 13, 2024
@ninjamuffin99
Copy link
Member

seems like Reg.getBounceImage() is checking to see if the created bitmap image is null or not, and it's being returned as non-null, when it should be null'd on the reset state in some way or another, since our graphic assumingly gets destroyed by flixel

The simple fix I've done is just remove that little check, might be bad practice, i'm actually still noob with doing destroy() on things and all that.

@ninjamuffin99 ninjamuffin99 linked a pull request Jan 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
next patch
3 participants
@sol-vin @Geokureli @ninjamuffin99