Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive xs-dev include does not find modules with manifest_*.json files #154

Open
HipsterBrown opened this issue Dec 27, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@HipsterBrown
Copy link
Owner

Calling xs-dev include without a full module name will bring up a searchable list of modules from the Moddable SDK by looking for directories containing manifest.json files. We should include these available directories that have .json files that include manifest as part of the file name.

The logic for selecting those directories is found here: https://github.com/HipsterBrown/xs-dev/blob/main/src/toolbox/prompt/choices.ts#L13-L14

This might require some further refactoring to provide the exact file path to the selected manifest rather than defaulting to append manifest.json to the directory path, seen here: https://github.com/HipsterBrown/xs-dev/blob/main/src/commands/include.ts#L57

@HipsterBrown HipsterBrown added the enhancement New feature or request label Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant