You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Expected behavior
It is expected for Github Action to fail, as the test cases have failed.
Screenshots
Must gather (please complete the following information):
SDK Version [e.g. 1.2.1] - v0.36.0
Go Version [e.g. 1.12.15] - go1.18.1 darwin/amd64
Name of service that you're trying to use (if applicable)
Name of operation that you're trying to invoke (if applicable)
Additional context
It is expected for Github Action to fail, if the test cases are failing. This breaks the basic idea of building and testing the PR before merging it to the master.
Point to mention that we have Travis build for merge commits only.
The text was updated successfully, but these errors were encountered:
@moisesatwork I believe we will need to write custom scripts for CodeQL to run the build in the first place. Right now, the build is auto generated, hence most of the test cases are skipped.
Also, 1 more important point to note here is that the integration test cases need env files to run, which we will have to encrypt in order to use during the build. (Similar to how we do for Travis builds)
Describe the bug
We noted that Build for Github Action did not fail even after the test cases failed.
To Reproduce
Expected behavior
It is expected for Github Action to fail, as the test cases have failed.
Screenshots
Must gather (please complete the following information):
Additional context
It is expected for Github Action to fail, if the test cases are failing. This breaks the basic idea of building and testing the PR before merging it to the master.
Point to mention that we have Travis build for merge commits only.
The text was updated successfully, but these errors were encountered: