Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Host TensorflowJS instead of using CDN #350

Closed
dalelane opened this issue Nov 9, 2020 · 0 comments · Fixed by #353
Closed

Host TensorflowJS instead of using CDN #350

dalelane opened this issue Nov 9, 2020 · 0 comments · Fixed by #353

Comments

@dalelane
Copy link
Member

dalelane commented Nov 9, 2020

TensorflowJS is currently hosted from unpkg.com

return utilService.loadScript('https://unpkg.com/@tensorflow/[email protected]/dist/tf.js');

return utilService.loadScript('https://unpkg.com/@tensorflow-models/[email protected]');

I've got other things I need to use it for, so it'll be helpful to move it into the site's hosted dependencies instead of getting it from an external site.

It would be good to try and update to the latest version as part of this, rather than remaining on 1.5.x

This will simplify the CSP requirements, too - as it'll be one fewer thing to need to add an override for. (cf. #346 )

dalelane added a commit that referenced this issue Nov 9, 2020
TensorflowJS and D3 were being loaded from unpkg.com but are now
hosted with the rest of dependencies fetched by bower.

I've also updated to a newer version of tfjs, and fixed a minor
bug that caused console errors if you click away from the models
page while leaving the model running for a test.

Closes: #350

Signed-off-by: Dale Lane <[email protected]>
dalelane added a commit that referenced this issue Nov 10, 2020
TensorflowJS and D3 were being loaded from unpkg.com but are now
hosted with the rest of dependencies fetched by bower.

I've also updated to a newer version of tfjs, and fixed a minor
bug that caused console errors if you click away from the models
page while leaving the model running for a test.

Closes: #350

Signed-off-by: Dale Lane <[email protected]>
dalelane added a commit that referenced this issue Nov 10, 2020
TensorflowJS and D3 were being loaded from unpkg.com but are now
hosted with the rest of dependencies fetched by bower.

I've also updated to a newer version of tfjs, and fixed a minor
bug that caused console errors if you click away from the models
page while leaving the model running for a test.

Closes: #350

Signed-off-by: Dale Lane <[email protected]>
dalelane added a commit that referenced this issue Nov 10, 2020
TensorflowJS and D3 were being loaded from unpkg.com but are now
hosted with the rest of dependencies fetched by bower.

I've also updated to a newer version of tfjs, and fixed a minor
bug that caused console errors if you click away from the models
page while leaving the model running for a test.

Closes: #350

Signed-off-by: Dale Lane <[email protected]>
dalelane added a commit that referenced this issue Nov 10, 2020
TensorflowJS and D3 were being loaded from unpkg.com but are now
hosted with the rest of dependencies fetched by bower.

I've also updated to a newer version of tfjs, and fixed a minor
bug that caused console errors if you click away from the models
page while leaving the model running for a test.

Closes: #350

Signed-off-by: Dale Lane <[email protected]>
dalelane added a commit that referenced this issue Nov 10, 2020
TensorflowJS and D3 were being loaded from unpkg.com but are now
hosted with the rest of dependencies fetched by bower.

I've also updated to a newer version of tfjs, and fixed a minor
bug that caused console errors if you click away from the models
page while leaving the model running for a test.

Closes: #350

Signed-off-by: Dale Lane <[email protected]>
dalelane added a commit that referenced this issue Nov 10, 2020
TensorflowJS and D3 were being loaded from unpkg.com but are now
hosted with the rest of dependencies fetched by bower.

I've also updated to a newer version of tfjs, and fixed a minor
bug that caused console errors if you click away from the models
page while leaving the model running for a test.

Closes: #350

Signed-off-by: Dale Lane <[email protected]>
dalelane added a commit that referenced this issue Nov 10, 2020
dalelane added a commit that referenced this issue Nov 15, 2020
Contributes to: #351
Contributes to: #350

Signed-off-by: Dale Lane <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant