Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator should include a tests using a non-square image to test for x,y transposition errors etc. #25

Open
zimeon opened this issue Jun 10, 2015 · 2 comments

Comments

@zimeon
Copy link
Member

zimeon commented Jun 10, 2015

Suggested by Jeremy Echols on iiif-discuss

Yes, I did use the validator. I found it to be EXTREMELY helpful, actually, as I was previously just kind of testing and hoping :)

There was only one issue I noticed - the test image is square, so it didn't catch a bug I had made in resizing where I had accidentally swapped width and height. It might be helpful to have a test image that isn't a perfect square, but I don't know how often such a stupid bug is likely to hit others, so it may be more time to do that than it's worth

I notes that having a non-square image also will allow checking that the direction of rotation is correct and that the axis for mirroring is correct.

@azaroth42
Copy link
Member

👍 I think there should be one non-square image. For 2.1 we can generate a new image, also for the square region, which is otherwise the entire image.

@zimeon
Copy link
Member Author

zimeon commented Jun 10, 2015

I guess there is no reason at all to have a square image so I agree that making the one test image non-square solves the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants